New issue
Advanced search Search tips

Issue 741970 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jan 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Add Style testcases to waterfall benchmark

Project Member Reported by nainar@chromium.org, Jul 13 2017

Issue description

Tracks progress shend@ and I are making on adding tests cases to PerformanceTests for CSS and Style
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/774d625ddca90b9c36dd4e26a849dcb03306f7f6

commit 774d625ddca90b9c36dd4e26a849dcb03306f7f6
Author: Naina Raisinghani <nainar@chromium.org>
Date: Wed Jul 19 03:05:00 2017

Add testcases to PerformanceTests/CSS to test changing style in trees of different depth

This CL adds a utils file that allows us to create a DOM tree of
varying depth and branch factor.

We use this file to create trees with:
1. Shallow tree (depth=2) with high branching factor(10)
2. Deep tree (depth=10) with small branching factor(2)

We then change the style of all elements in the tree and benchmark the
number of runs done in a second. This allows us to set up a benchmark
for style manipulation as a benchmark is not currently present.

Bug:  741970 
Change-Id: I90bf5d16ceefb6d79c7bbbc3657d8202ca49b89d
Reviewed-on: https://chromium-review.googlesource.com/569421
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487731}
[add] https://crrev.com/774d625ddca90b9c36dd4e26a849dcb03306f7f6/third_party/WebKit/PerformanceTests/CSS/ChangeStyleDeepTree.html
[add] https://crrev.com/774d625ddca90b9c36dd4e26a849dcb03306f7f6/third_party/WebKit/PerformanceTests/CSS/ChangeStyleShallowTree.html
[add] https://crrev.com/774d625ddca90b9c36dd4e26a849dcb03306f7f6/third_party/WebKit/PerformanceTests/CSS/resources/utils.js

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad0ccd37620cfc7e6cd1030ae323a6df051c1e7c

commit ad0ccd37620cfc7e6cd1030ae323a6df051c1e7c
Author: Naina Raisinghani <nainar@chromium.org>
Date: Wed Jul 19 07:02:54 2017

Add testcases to PerformanceTests/CSS to test changing style using selectors

This CL amends the utils file to add a DOM tree generator function.

We then change the style of all elements in the tree and benchmark the
time spent. This allows us to set up a benchmark for style manipulation
done using selectors.

Bug:  741970 
Change-Id: Ic95054f5a849519713c60192c245e75dac73d341
Reviewed-on: https://chromium-review.googlesource.com/572801
Commit-Queue: nainar <nainar@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487774}
[modify] https://crrev.com/ad0ccd37620cfc7e6cd1030ae323a6df051c1e7c/third_party/WebKit/PerformanceTests/CSS/ChangeStyleDeepTree.html
[add] https://crrev.com/ad0ccd37620cfc7e6cd1030ae323a6df051c1e7c/third_party/WebKit/PerformanceTests/CSS/ChangeStyleNestedPseudoSelector.html
[add] https://crrev.com/ad0ccd37620cfc7e6cd1030ae323a6df051c1e7c/third_party/WebKit/PerformanceTests/CSS/ChangeStylePairOfNthChildSelector.html
[modify] https://crrev.com/ad0ccd37620cfc7e6cd1030ae323a6df051c1e7c/third_party/WebKit/PerformanceTests/CSS/ChangeStyleShallowTree.html
[add] https://crrev.com/ad0ccd37620cfc7e6cd1030ae323a6df051c1e7c/third_party/WebKit/PerformanceTests/CSS/ChangeStyleSingleNthChildSelector.html
[add] https://crrev.com/ad0ccd37620cfc7e6cd1030ae323a6df051c1e7c/third_party/WebKit/PerformanceTests/CSS/ChangeStyleSinglePseudoSelector.html
[modify] https://crrev.com/ad0ccd37620cfc7e6cd1030ae323a6df051c1e7c/third_party/WebKit/PerformanceTests/CSS/resources/utils.js

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee8ec000bf3c6f2e750599186a1af42e21a8b241

commit ee8ec000bf3c6f2e750599186a1af42e21a8b241
Author: Naina Raisinghani <nainar@chromium.org>
Date: Thu Jul 20 05:45:30 2017

Add testcases to PerformanceTests/CSS to test changing style using selectors

We then change the style of all elements in the tree and benchmark the
time spent. This allows us to set up a benchmark for style manipulation
done using selectors.

This adds test to apply pseudo selectors on:
1. Children of elements
2. Grand children of elements
3. All elements (universal selector)
4. Checking for partrial match for an attribute

Bug:  741970 
Change-Id: Idb1cb91fbbcc20044cf902bb5e193cb7a73343e0
Reviewed-on: https://chromium-review.googlesource.com/577330
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488145}
[add] https://crrev.com/ee8ec000bf3c6f2e750599186a1af42e21a8b241/third_party/WebKit/PerformanceTests/CSS/ChangeStyleChildElementSelectors.html
[add] https://crrev.com/ee8ec000bf3c6f2e750599186a1af42e21a8b241/third_party/WebKit/PerformanceTests/CSS/ChangeStyleElementSelector.html
[add] https://crrev.com/ee8ec000bf3c6f2e750599186a1af42e21a8b241/third_party/WebKit/PerformanceTests/CSS/ChangeStyleGrandChildElementSelector.html
[add] https://crrev.com/ee8ec000bf3c6f2e750599186a1af42e21a8b241/third_party/WebKit/PerformanceTests/CSS/ChangeStylePartialAttributeMatchingSelector.html
[add] https://crrev.com/ee8ec000bf3c6f2e750599186a1af42e21a8b241/third_party/WebKit/PerformanceTests/CSS/ChangeStyleSinglePseudoSelector.html~HEAD
[add] https://crrev.com/ee8ec000bf3c6f2e750599186a1af42e21a8b241/third_party/WebKit/PerformanceTests/CSS/ChangeStyleUniversalSelector.html

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5b7a6c5fdb3991524fc959cdfcfaf69ebac3795

commit d5b7a6c5fdb3991524fc959cdfcfaf69ebac3795
Author: Darren Shen <shend@chromium.org>
Date: Mon Jul 24 07:17:36 2017

Add testcases to PerformanceTests/CSS to test changing style using selectors

This patch adds perf tests for different varieties of class and data
attribute selectors (e.g. (qualified/unqualified) data attribute selectors,
(single/multiple) class selectors)

Bug:  741970 
Change-Id: I79ef4d3ad071d1bd332fa00160941bc9877b4e81
Reviewed-on: https://chromium-review.googlesource.com/575326
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488927}
[add] https://crrev.com/d5b7a6c5fdb3991524fc959cdfcfaf69ebac3795/third_party/WebKit/PerformanceTests/CSS/ChangeStyleChildClassSelector.html
[add] https://crrev.com/d5b7a6c5fdb3991524fc959cdfcfaf69ebac3795/third_party/WebKit/PerformanceTests/CSS/ChangeStyleMultipleClassSelector.html
[add] https://crrev.com/d5b7a6c5fdb3991524fc959cdfcfaf69ebac3795/third_party/WebKit/PerformanceTests/CSS/ChangeStyleMultipleQualifiedDataAttributesWithValuesSelector.html
[add] https://crrev.com/d5b7a6c5fdb3991524fc959cdfcfaf69ebac3795/third_party/WebKit/PerformanceTests/CSS/ChangeStyleQualifiedDataAttributeSelector.html
[add] https://crrev.com/d5b7a6c5fdb3991524fc959cdfcfaf69ebac3795/third_party/WebKit/PerformanceTests/CSS/ChangeStyleQualifiedDataAttributeWithValueSelector.html
[add] https://crrev.com/d5b7a6c5fdb3991524fc959cdfcfaf69ebac3795/third_party/WebKit/PerformanceTests/CSS/ChangeStyleSingleClassSelector.html
[add] https://crrev.com/d5b7a6c5fdb3991524fc959cdfcfaf69ebac3795/third_party/WebKit/PerformanceTests/CSS/ChangeStyleUnqualifiedDataAttributeSelector.html
[add] https://crrev.com/d5b7a6c5fdb3991524fc959cdfcfaf69ebac3795/third_party/WebKit/PerformanceTests/CSS/ChangeStyleUnqualifiedDataAttributeWithValueSelector.html
[modify] https://crrev.com/d5b7a6c5fdb3991524fc959cdfcfaf69ebac3795/third_party/WebKit/PerformanceTests/CSS/resources/utils.js

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a65c9b380ae231c5b23ac16573e593260ca575ed

commit a65c9b380ae231c5b23ac16573e593260ca575ed
Author: Darren Shen <shend@chromium.org>
Date: Tue Jul 25 01:09:19 2017

Add bootstrap loading perf tests.

This patch adds the sample blog page at [1] and a components page at [2]
as blink_perf performance tests.

[1] https://getbootstrap.com/examples/blog/
[2] https://bootswatch.com/default/

Bug:  741970 
Change-Id: I4db1c57605002200995f552e4952e01b2aba9433
Reviewed-on: https://chromium-review.googlesource.com/578828
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489172}
[add] https://crrev.com/a65c9b380ae231c5b23ac16573e593260ca575ed/third_party/WebKit/PerformanceTests/CSS/LoadBootstrapBlog.html
[add] https://crrev.com/a65c9b380ae231c5b23ac16573e593260ca575ed/third_party/WebKit/PerformanceTests/CSS/LoadBootstrapComponents.html
[modify] https://crrev.com/a65c9b380ae231c5b23ac16573e593260ca575ed/third_party/WebKit/PerformanceTests/CSS/resources/bootstrap.min.css

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64da9eb5617cc3227550a1ae1cb6789f4be31470

commit 64da9eb5617cc3227550a1ae1cb6789f4be31470
Author: Naina Raisinghani <nainar@chromium.org>
Date: Tue Jul 25 02:01:19 2017

Add Materialize loading perf test.

This patch adds the sample page at [1] as a blink_perf performance test.

[1] http://materializecss.com/templates/starter-template/preview.html

Bug:  741970 
Change-Id: I2b0dee5371006f658e2b4716595c00124e0bb97e
Reviewed-on: https://chromium-review.googlesource.com/580121
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489185}
[add] https://crrev.com/64da9eb5617cc3227550a1ae1cb6789f4be31470/third_party/WebKit/PerformanceTests/CSS/LoadMaterializeStarterPage.html
[add] https://crrev.com/64da9eb5617cc3227550a1ae1cb6789f4be31470/third_party/WebKit/PerformanceTests/CSS/resources/materialize.min.css

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b6076c0973e7eb24cc3cea3bb8d00112eddda3c

commit 7b6076c0973e7eb24cc3cea3bb8d00112eddda3c
Author: Naina Raisinghani <nainar@chromium.org>
Date: Tue Jul 25 14:34:19 2017

Add Semantic UI loading perf test.

This patch adds the sample page at [1] as a blink_perf performance test.

[1] https://semantic-ui.com/examples/sticky.html

Bug:  741970 
Change-Id: I3a68ed59d99d8a382f89d12babe8477c8dbf1c65
Reviewed-on: https://chromium-review.googlesource.com/579893
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489287}
[add] https://crrev.com/7b6076c0973e7eb24cc3cea3bb8d00112eddda3c/third_party/WebKit/PerformanceTests/CSS/LoadSemanticPageExample.html
[add] https://crrev.com/7b6076c0973e7eb24cc3cea3bb8d00112eddda3c/third_party/WebKit/PerformanceTests/CSS/resources/semantic.min.css

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b4861c918480bf1ee5e30f1501befad9d2d31d2

commit 3b4861c918480bf1ee5e30f1501befad9d2d31d2
Author: Darren Shen <shend@chromium.org>
Date: Mon Sep 11 01:54:57 2017

Add parsing trace events to stylesheet loading performance tests.

This patch adds trace events for parsing to some relevant blink_perf.css
performance tests.

Bug:  741970 
Change-Id: I06d1ed087226834131b75ac58432f074a6b263eb
Reviewed-on: https://chromium-review.googlesource.com/656639
Reviewed-by: nainar <nainar@chromium.org>
Reviewed-by: Rune Lillesveen <rune@opera.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500826}
[modify] https://crrev.com/3b4861c918480bf1ee5e30f1501befad9d2d31d2/third_party/WebKit/PerformanceTests/CSS/LoadBootstrapBlog.html
[modify] https://crrev.com/3b4861c918480bf1ee5e30f1501befad9d2d31d2/third_party/WebKit/PerformanceTests/CSS/LoadMaterializeStarterPage.html
[modify] https://crrev.com/3b4861c918480bf1ee5e30f1501befad9d2d31d2/third_party/WebKit/PerformanceTests/CSS/LoadSemanticPageExample.html

Comment 9 by shend@chromium.org, Oct 11 2017

Components: Blink>CSS
Owner: ----
Status: Available (was: Assigned)
Labels: Performance
Labels: Update-Quarterly
Labels: Code-Tests ApproachableBug
Labels: -Update-Quarterly
Labels: -Performance -Type-Bug Type-Feature
Project Member

Comment 15 by sheriffbot@chromium.org, Jan 18 (5 days ago)

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 16 by e...@chromium.org, Jan 21 (2 days ago)

Status: WontFix (was: Untriaged)

Sign in to add a comment