New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 741968 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
inactive
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[Feedback Beta] Copy does not work - 60.0.3112.50

Project Member Reported by jainabhi...@chromium.org, Jul 13 2017

Issue description

Chrome Version: 60.0.3112.50
OS: Android

Feedback
Since the last update the button "Copy" does not work anymore! htc_pmeuhl
Copy/paste is broken. I copy something on the page and then paste it in a textarea but it pastes something else. Nexus 5 (b/63623616)
 
Cc: ram...@chromium.org
Labels: triage-te
ramine@, can you check this is M60?  In the b/ bug, you had tested on M59.

Comment 2 by ram...@chromium.org, Jul 13 2017

Labels: -triage-te Needs-Feedback
Device: Nexus 5/6.0.1
Chrome version: 60.0.3112.50

Steps:
1. Launch Chrome
2. Visit 'reddit.com' web site
3. Copy some text.
4. Open an editable text field 'Add comment' and paste.

Successfully pasted text in edit field.

Can you share a video and what device was used for this test.
Thanks.
Cc: amineer@chromium.org
Labels: M-60
Device : Nexus 5 | Chrome Version : 60.0.3112.50
Details for original bug poster.

We are also getting some reports about this issue at 1% rollout
Device : Samsung Galaxy S7 edge | Chrome version : 60.0.3112.78
http://feedback/#/Report/69646928426
Cc: changwan@chromium.org aelias@chromium.org
+aelias / changwan since this is an input issue.

Please also see related b/ bug linked in c#0.

Any ideas on what this might be?
Labels: Needs-Bisect
I was able to repro on reddit.com after pressing "Request Desktop Site", at maybe 50% repro rate.  I long-press selected words in "submitted 20 hours ago" text and pressed "copy", then tried pasting them in the URL-bar, but half the time it's still the previous word.  This is on 60.0.3112.78 with Galaxy S7 SM-G930U.

Is that enough for test team to repro and bisect?
I am able to repro this once out of 20-30 trials which makes it difficult to bisect. Per https://b.corp.google.com/issues/63623616#comment5 it appears to be flaky once it works it works and randomly stops working.
I tried on same device as reporter Nexus 5/6.0.0 and Pixel/N
Cc: dskloet@google.com
So far, I believe this is a reddit-specific issue because I haven't been able to repro on any other site.  If it's reddit-specific, we don't need to block release.  If it reproes elsewhere, then it's scarier, so please note if you reproed this on any non-reddit site.
Owner: aelias@chromium.org
Status: Assigned (was: Untriaged)
OK, I found a consistent repro today and it affects any site.  Repro on M60, no repro on M59 or M61.

1. Search for "foo" on google.com.
2. Long-press on a link.
3. Tap once anywhere to dismiss link context menu.
4. Long-press on some text.
5. Click "Copy".

Now if you paste anywhere (e.g. in URL-bar), you'll observe text is not pasted.  Notes:

- Repeating steps 4 and 5 still reproes the problem, but single-tapping anywhere empty clears out the problem and you need to perform the initial steps again to repro.
- Instead of long-pressing a link, you can equivalently single-tap to focus a textbox to repro the issue.
Owner: jinsuk...@chromium.org
Jinsuk, since it's still workday for you, can you bisect for the culprit and fix and help decide what we should do?
Status: Started (was: Assigned)
Cc: amaralp@chromium.org xiaoche...@chromium.org
Labels: -Needs-Feedback -Needs-Bisect
Owner: aelias@chromium.org
Bisect results show that r472985 introduced the issue, and r476355 made it disappear. Assigning back to aelias@ for the next move..
Labels: Merge-Request-60
Thanks!  I have discussed offline reverting r472985 with xiaochengh@ and we agree that it's safe and appropriate to revert.  Requesting merge of revert of r472985 to M60.

Severity: High - text does not copy into clipboard for a given website.  The problem happens indefinitely/repeated and although there is a workaround (single-tap anywhere empty on the page), users have no way to discover it except by luck.
Users affected: 100% of Android Chrome users who copy/paste.  The repro scenario is somewhat obscure so this will not happen every day, but this has personally affected me about 5 times during the 60 beta period.

Other notes:
Patch r476355 fixes a very minor/theoretical problem with spatial navigation copy/paste which has not been reported by a real user and which xiaochengh@ and I believe would affect a vanishingly small user population and use case (tabbing to a link and expecting link text to be copied with Ctrl-C), and no other code should depend on it.  So we believe it's safe to revert at the last minute.
amineer@ tells me the latest 60 build has already gone through final testing and has no other blockers to go out.  Reluctantly, I would say this is somewhat under the "users affected" threshold and probably doesn't justify another full test pass and respin on its own.

The main reason is that it does not affect copy/paste entirely within textboxes or form fields which is the key use case for copy/paste, and the other reason is that the repro is flaky enough when it does happen that the user is likely to eventually succeed by retrying.

So not marking RBS, although if there arises another reason for respin, the revert is safe enough and the severity is still high enough I'd like to slip it in.
Labels: -Merge-Request-60 Merge-Approved-60 Merge-Approved-61
Merge approved for M60 branch 3112 and M61 branch 3163.
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 10 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef6a22fba8fcf2ab5f17e4ac6cad171efb7b6700

commit ef6a22fba8fcf2ab5f17e4ac6cad171efb7b6700
Author: Alexandre Elias <aelias@chromium.org>
Date: Thu Aug 10 00:13:41 2017

Revert "Fix behavior of clipboard commands when there is unfocused selection" on M60.

This reverts commit f8ff4f535ca35569ff840d9ffb71bb3e9e5d3ee1 on M60
branch.  Causes Android copy/paste regression  http://crbug.com/741968 
only on M60.

BUG= 741968 , 722925 
TBR=xiaochengh@chromium.org
TEST=Long-press on links, focus on textboxes, then select "normal" text outside
textboxes and try to copy/paste it.

Change-Id: I48a6a80e56cb4e5bb7ea69564303a4beab43741a
Reviewed-on: https://chromium-review.googlesource.com/609375
Reviewed-by: Alexandre Elias <aelias@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#718}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[delete] https://crrev.com/35e343db69f214e4ad8f741febf8c2dccc54fd10/third_party/WebKit/LayoutTests/editing/pasteboard/pasteboard_with_unfocused_selection.html
[modify] https://crrev.com/ef6a22fba8fcf2ab5f17e4ac6cad171efb7b6700/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/ef6a22fba8fcf2ab5f17e4ac6cad171efb7b6700/third_party/WebKit/Source/core/editing/Editor.h
[modify] https://crrev.com/ef6a22fba8fcf2ab5f17e4ac6cad171efb7b6700/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
[modify] https://crrev.com/ef6a22fba8fcf2ab5f17e4ac6cad171efb7b6700/third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp

Labels: -Merge-Approved-61
Status: Fixed (was: Started)
No action needed on M61 as it went away after r476355.
Issue mentioned in #2 and #9 reproducible on 60 but not in 59 and 61 NO LONGER reproducible in 60.0.3112.107
Tested google.com and searched foo and copy link test from the search results and copied selected text  and try to paste in URL in Chrome pasted the text .Also tried reddit url and verified the fix.
Verified fix with steps from #9 in 60.0.3112.107 / Samsung Galaxy Grand Prime / LRX22G.

Sign in to add a comment