deploy_chrome does not check remote device's BOARD name |
|||
Issue description
What steps will reproduce the problem?
(1) BOARD=veyron_minnie; cros chrome-sdk --board=$BOARD --internal
(2) ninja -C out_${SDK_BOARD}/Release -j500 chrome chrome_sandbox nacl_helper
(3) deploy_chrome --build-dir=out_${SDK_BOARD}/Release --to=caroline_ipaddr
What is the expected result?
Step #3 fails because out_${SDK_BOARD}/Release/chrome is built for minnie but the remote device is caroline.
What happens instead?
It succeeds, and the remote device becomes unusable.
,
Jul 13 2017
Bug or feature? I could imagine someone making use of this if they want to deploy a Chrome build that's of the correct architecture but for a different board -- that should generally work, right? Maybe deploy_chrome could just check the arch instead.
,
Jul 13 2017
,
Jul 14 2017
How about printing a warning (device is different from target board, continue? y/N) and adding a flag to skip it?
,
Jul 14 2017
+1. #4 is consistent with what cros deploy does.
,
Jul 14 2017
BTW, this is unlikely to be picked up by anyone. I added it to Hotlist-CrOS-Gardener but that's a huge list and few gardeners get around to picking any of those tasks up. If you want this feature you should plan to work on it (maybe during your next gardener shift). I am happy to point someone in the right direction.
,
Jun 8 2018
Hi, this bug has not been updated recently. Please acknowledge the bug and provide status within two weeks (6/22/2018), or the bug will be archived. Thank you. |
|||
►
Sign in to add a comment |
|||
Comment 1 by steve...@chromium.org
, Jul 13 2017Labels: Hotlist-CrOS-Gardener