Compositing broken, get gray boxes |
|||||
Issue descriptionChrome Version: Version 61.0.3153.4 (Official Build) dev (64-bit) OS: Mac 10.11.6 (15G1510) Repro: Go to G+. Compositing of transparent objects is broken; there is a gray box that appears outside of it. See attached screenshots, one of Netflix, one of G+.
,
Jul 13 2017
Here's the regression range: https://chromium.googlesource.com/chromium/src/+log/cc3f9c3f3c57b1a4e0c506828932c0c46170e723..d43ca17f375b2f0cefc8ccaffa22e0c72ea6c040 I think this is probably: "converted GrCircleBlurFragmentProcessor to sksl" https://skia.googlesource.com/skia.git/+/9b80ffc77b8000b493eb1226dc6ec21f1e99edfc
,
Jul 13 2017
This works in my non-updated Canary, and the elements for which this is happening have drop shadows, so that CL looks like a plausible suspect.
,
Jul 13 2017
This works in Version 61.0.3155.0 (Official Build) canary (64-bit) and Version 61.0.3156.0 (Official Build) canary (64-bit) So that's kinda weird; was that already reverted?
,
Jul 13 2017
Looking at the original review (https://skia-review.googlesource.com/c/21727/) I think this has been reverted: https://skia-review.googlesource.com/c/22266/ Maybe it's possible to add a test for this though?
,
Jul 13 2017
It was re-landed today at https://skia-review.googlesource.com/c/22369/ by Greg Daniel. cc-ing. Greg, can you confirm that this was fixed in your re-landing?
,
Jul 13 2017
,
Jul 13 2017
I patched in the latest roll (https://chromium-review.googlesource.com/c/570189/) which re-adds the patch, and it seems to work in a local build. I'll wait to see if the official roll works well too.
,
Jul 13 2017
You beat me to it; my own Chrome build was still going. Glad to hear it's ok now.
,
Jul 14 2017
This seems to be fixed on ToT at 79eb827de6b9. Closing.
,
Jul 18 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by a...@chromium.org
, Jul 13 201721.0 KB
21.0 KB View Download