New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 741953 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 735994



Sign in to add a comment

Remove CloseSystemBubble in SystemTray which is redundant with CloseBubble.

Project Member Reported by minch@chromium.org, Jul 13 2017

Issue description

Remove CloseSystemBubble in SystemTray which is redundant with CloseBubble.
 

Comment 1 by minch@chromium.org, Jul 13 2017

Blocking: 735994

Comment 2 by minch@chromium.org, Jul 26 2017

Labels: M-61
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bab44af86b9eae11aa3938b404388312582a9d12

commit bab44af86b9eae11aa3938b404388312582a9d12
Author: MinChen <minch@chromium.org>
Date: Thu Jul 27 23:18:24 2017

Remove CloseSystemBubble in SysteTray and use CloseBubble instead.

Bug:  741953 
Change-Id: If84dc5d589e3241a93c98da8f3faa86539ae3435
Reviewed-on: https://chromium-review.googlesource.com/578233
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: min c <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490082}
[modify] https://crrev.com/bab44af86b9eae11aa3938b404388312582a9d12/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/bab44af86b9eae11aa3938b404388312582a9d12/ash/first_run/first_run_helper_impl.cc
[modify] https://crrev.com/bab44af86b9eae11aa3938b404388312582a9d12/ash/system/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/bab44af86b9eae11aa3938b404388312582a9d12/ash/system/enterprise/tray_enterprise_unittest.cc
[modify] https://crrev.com/bab44af86b9eae11aa3938b404388312582a9d12/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/bab44af86b9eae11aa3938b404388312582a9d12/ash/system/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/bab44af86b9eae11aa3938b404388312582a9d12/ash/system/screen_security/screen_tray_item_unittest.cc
[modify] https://crrev.com/bab44af86b9eae11aa3938b404388312582a9d12/ash/system/session/tray_session_length_limit_unittest.cc
[modify] https://crrev.com/bab44af86b9eae11aa3938b404388312582a9d12/ash/system/tray/actionable_view.cc
[modify] https://crrev.com/bab44af86b9eae11aa3938b404388312582a9d12/ash/system/tray/system_tray.cc
[modify] https://crrev.com/bab44af86b9eae11aa3938b404388312582a9d12/ash/system/tray/system_tray.h
[modify] https://crrev.com/bab44af86b9eae11aa3938b404388312582a9d12/ash/system/tray/system_tray_controller.cc
[modify] https://crrev.com/bab44af86b9eae11aa3938b404388312582a9d12/ash/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/bab44af86b9eae11aa3938b404388312582a9d12/ash/system/tray_accessibility.cc
[modify] https://crrev.com/bab44af86b9eae11aa3938b404388312582a9d12/ash/system/user/tray_user_unittest.cc
[modify] https://crrev.com/bab44af86b9eae11aa3938b404388312582a9d12/ash/system/user/user_view.cc
[modify] https://crrev.com/bab44af86b9eae11aa3938b404388312582a9d12/chrome/browser/chromeos/accessibility/sticky_keys_browsertest.cc
[modify] https://crrev.com/bab44af86b9eae11aa3938b404388312582a9d12/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
[modify] https://crrev.com/bab44af86b9eae11aa3938b404388312582a9d12/chrome/browser/chromeos/shutdown_policy_browsertest.cc
[modify] https://crrev.com/bab44af86b9eae11aa3938b404388312582a9d12/chrome/browser/ui/ash/networking_config_delegate_chromeos_browsertest.cc
[modify] https://crrev.com/bab44af86b9eae11aa3938b404388312582a9d12/chrome/browser/ui/ash/system_tray_client_browsertest.cc

Comment 4 by minch@chromium.org, Jul 28 2017

Labels: Merge-Request-61 OS-Chrome
touch gestures on tray area for 61.
Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 1 2017

Cc: keta...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 3 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb716a11e7af5bb3d04b101b1e49a797567917e4

commit fb716a11e7af5bb3d04b101b1e49a797567917e4
Author: xdai <xdai@chromium.org>
Date: Thu Aug 03 22:16:12 2017

[Merge to M61] Remove CloseSystemBubble in SysteTray and use CloseBubble instead.

Merge this CL back to M61 on behalf of minch@.

TBR=oshima@chromium.org
(cherry picked from commit bab44af86b9eae11aa3938b404388312582a9d12)

Bug:  741953 
Change-Id: If84dc5d589e3241a93c98da8f3faa86539ae3435
Reviewed-on: https://chromium-review.googlesource.com/578233
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: min c <minch@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490082}
Reviewed-on: https://chromium-review.googlesource.com/600864
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#292}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/fb716a11e7af5bb3d04b101b1e49a797567917e4/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/fb716a11e7af5bb3d04b101b1e49a797567917e4/ash/first_run/first_run_helper_impl.cc
[modify] https://crrev.com/fb716a11e7af5bb3d04b101b1e49a797567917e4/ash/system/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/fb716a11e7af5bb3d04b101b1e49a797567917e4/ash/system/enterprise/tray_enterprise_unittest.cc
[modify] https://crrev.com/fb716a11e7af5bb3d04b101b1e49a797567917e4/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/fb716a11e7af5bb3d04b101b1e49a797567917e4/ash/system/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/fb716a11e7af5bb3d04b101b1e49a797567917e4/ash/system/screen_security/screen_tray_item_unittest.cc
[modify] https://crrev.com/fb716a11e7af5bb3d04b101b1e49a797567917e4/ash/system/session/tray_session_length_limit_unittest.cc
[modify] https://crrev.com/fb716a11e7af5bb3d04b101b1e49a797567917e4/ash/system/tray/actionable_view.cc
[modify] https://crrev.com/fb716a11e7af5bb3d04b101b1e49a797567917e4/ash/system/tray/system_tray.cc
[modify] https://crrev.com/fb716a11e7af5bb3d04b101b1e49a797567917e4/ash/system/tray/system_tray.h
[modify] https://crrev.com/fb716a11e7af5bb3d04b101b1e49a797567917e4/ash/system/tray/system_tray_controller.cc
[modify] https://crrev.com/fb716a11e7af5bb3d04b101b1e49a797567917e4/ash/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/fb716a11e7af5bb3d04b101b1e49a797567917e4/ash/system/tray_accessibility.cc
[modify] https://crrev.com/fb716a11e7af5bb3d04b101b1e49a797567917e4/ash/system/user/tray_user_unittest.cc
[modify] https://crrev.com/fb716a11e7af5bb3d04b101b1e49a797567917e4/ash/system/user/user_view.cc
[modify] https://crrev.com/fb716a11e7af5bb3d04b101b1e49a797567917e4/chrome/browser/chromeos/accessibility/sticky_keys_browsertest.cc
[modify] https://crrev.com/fb716a11e7af5bb3d04b101b1e49a797567917e4/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
[modify] https://crrev.com/fb716a11e7af5bb3d04b101b1e49a797567917e4/chrome/browser/chromeos/shutdown_policy_browsertest.cc
[modify] https://crrev.com/fb716a11e7af5bb3d04b101b1e49a797567917e4/chrome/browser/ui/ash/networking_config_delegate_chromeos_browsertest.cc
[modify] https://crrev.com/fb716a11e7af5bb3d04b101b1e49a797567917e4/chrome/browser/ui/ash/system_tray_client_browsertest.cc

Comment 8 by minch@chromium.org, Aug 3 2017

Status: Fixed (was: Started)

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment