New issue
Advanced search Search tips

Issue 741944 link

Starred by 2 users
Status: Verified
Owner:
pkl@chromium.org
Closed: Jul 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Download UI "OPEN IN..." string shown during touch down state

Project Member Reported by pkl@chromium.org, Jul 13 2017 
App Version (from "Chrome Settings > About Chrome"): 59.0.3071.102
iOS Version: 10.3.2
Device: iPhone SE

Steps to reproduce: 
1. Set your phone to a non-English language (I used French)
2. Search for a zip file, e.g. "download zip file test". One of the results is likely from download.thinkbroadband.com. Tap on that.
3. Find a zip file and tap on it to bring up the Download UI.
4. Note that in the lower right corner is the button to download ("TELECHARGER").

Observed behavior: 
5. Touch down (but don't lift your finger immediately) and notice that the label changes to "DOWNLOAD" while touch is still down (i.e. displaying the English label).

Expected behavior: 
The label should stay in the UI language (French) and not change to English.

Frequency: 
<number of times you were able to reproduce> 

Additional comments:

Comment 1 by pkl@chromium.org, Jul 13 2017

Owner: pkl@chromium.org
Status: Assigned (was: Untriaged)
This is because the English string is in the XIB file and the code did not set the localized string for button's UIControlStateHighlighted state.

Comment 2 by pkl@chromium.org, Jul 13 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90d05ddca397539925af8cdd4a446c804b6332f1

commit 90d05ddca397539925af8cdd4a446c804b6332f1
Author: Peter K. Lee <pkl@chromium.org>
Date: Thu Jul 13 16:01:12 2017

Sets both Normal and Highlighted states for button titles

Button titles coming in from XIB needs to have both Normal and
Highlighted states set in code. Otherwise, the default non-translated
strings in the XIB file is displayed during Highlighted state.

Also done some refactoring to reduce verbosity.

Bug:  741944 
Change-Id: I4eb45deabd75d695f665565deb5ab6370097e0e1
Reviewed-on: https://chromium-review.googlesource.com/569339
Commit-Queue: Peter Lee <pkl@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486399}
[modify] https://crrev.com/90d05ddca397539925af8cdd4a446c804b6332f1/ios/chrome/browser/ui/downloads/download_manager_controller.mm

Comment 4 by pkl@chromium.org, Jul 13 2017

Labels: M-61
Status: Fixed (was: Started)

Comment 5 by subhashi...@chromium.org, Jul 18 2017

Status: Verified (was: Fixed)
Verified on:

App version: 61.0.3159.0 canary
Devices: iPhone5S, iPhone 6 Plus
iOS Version: 9.3.5, 10.3.1

'Download' label on 'Download Manager UI' is shown based on device language and long press on 'Download' label displayed in non-english language doesn't change to English. Hence marking this issue as 'Verified'.
►

Sign in to add a comment