New issue
Advanced search Search tips

Issue 741935 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

LayoutTest copy-standalone-image-crash.html passes without testing anything

Project Member Reported by jsb...@chromium.org, Jul 12 2017

Issue description

editing/pasteboard/copy-standalone-image-crash.html does:

* eventSender.contextClick()
* enumerates the actionitems
* looks for an item with title == "Copy Image"; if found, calls click() on it
* passes if there's no crash

The problem is that it passes if "Copy Image" is not found, which it isn't, for multiple reasons. For one, all of the actionitems are strings, so they have no .title or .click(). For another, "Copy Image" is nowhere to be seen:

"Back"
"Reload Page"
"Open in Dashbaord"
"<separator>"
"View Source"
"Save Page As"
"Print Page"
"Inspect Element"

This is from kNonEditableMenuStrings in content/shell/test_runner/event_sender.cc

Note "Dashbaord" because are are awesome.


 

Comment 1 by jsb...@chromium.org, Jul 12 2017

I guess we should just delete the test.

Comment 2 by yosin@chromium.org, Jul 13 2017

Labels: -Type-Bug Type-Task
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 13

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)

Sign in to add a comment