DCHECK on removing browsing data |
||
Issue descriptionThis problem may result in browsing data not being removed (I'm not entirely sure how this is used) so marking as a P1 in case that's true. In a debug build I signed into Chrome using my @google.com account. Then I went to settings and logged out (at the top), and accepted the "clear data" prompt. This asserts in chrome_browsing_data_remover_delegate.cc with an invalid GURL. WebsiteSettingsFilterAdapter has this code: // Website settings only use origin-scoped patterns. The only content setting // currently supported by ChromeBrowsingDataRemoverDelegate is // DURABLE_STORAGE, which also only uses origin-scoped patterns. Such patterns // can be directly translated to a GURL. GURL url(primary_pattern.ToString()); DCHECK(url.is_valid()); return predicate.Run(url); This comment and the code below are incorrect. In my case, primary_pattern.ToString() is returning the string "ca-service.corp.google.com" which is not a URL. This is because the content setting uses a wildcard scheme. GURL reduces to an empty GURL which is invalid. I'm assuming data associated with this policy will not be removed as a result.
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6175fbae15f0377390f8262593a5d3da4305f17 commit e6175fbae15f0377390f8262593a5d3da4305f17 Author: Christian Dullweber <dullweber@chromium.org> Date: Fri Jul 14 09:20:27 2017 Make content settings non-filterable Content Settings don't need to be filterable and using WebsiteSettingsFilterAdapter doesn't work in some cases. Bug: 741934 Change-Id: I765cd9683079fa7592afc3aedc0ea0f243d782ed Reviewed-on: https://chromium-review.googlesource.com/570241 Reviewed-by: Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#486711} [modify] https://crrev.com/e6175fbae15f0377390f8262593a5d3da4305f17/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc [modify] https://crrev.com/e6175fbae15f0377390f8262593a5d3da4305f17/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h [modify] https://crrev.com/e6175fbae15f0377390f8262593a5d3da4305f17/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
,
Jul 14 2017
Content settings shouldn't be filtered anymore |
||
►
Sign in to add a comment |
||
Comment 1 by msramek@chromium.org
, Jul 13 2017Owner: dullweber@chromium.org