--test-launcher-jobs flag ignored when also using --gtest_filter |
|||
Issue descriptionExecuting tests like below creates 1 job instead of N jobs: ./unit_tests --gtest_filter=MediaRouter* --test-launcher-jobs=10 This seems to be due to this change: https://chromium-review.googlesource.com/c/549342/ In TestLauncher::NumParallelJobs() method, the if and else-if clauses got reversed, and that seems to be causing the change in behavior.
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1b412c80b1bbecf4f6bc663a6e7e061b71a6269 commit f1b412c80b1bbecf4f6bc663a6e7e061b71a6269 Author: Mostyn Bramley-Moore <mostynb@opera.com> Date: Fri Jul 14 16:33:54 2017 --gtest_filter should only change NumParallelJobs' default value BUG= 741927 , 735587 Change-Id: Ib95bd85e2f1ad14e27ba8fa76f8b52f8e137e830 Reviewed-on: https://chromium-review.googlesource.com/569159 Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com> Cr-Commit-Position: refs/heads/master@{#486773} [modify] https://crrev.com/f1b412c80b1bbecf4f6bc663a6e7e061b71a6269/base/test/launcher/test_launcher.cc
,
Jul 14 2017
,
Jul 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb12aa53060d9397de49ed5c2e72a0bdf36833e2 commit eb12aa53060d9397de49ed5c2e72a0bdf36833e2 Author: Mostyn Bramley-Moore <mostynb@opera.com> Date: Sun Jul 16 17:45:42 2017 don't forget to actually return the number of specified test jobs BUG= 741927 , 743615 TEST=Running browser_tests with the flags below, should print "Using 1 parallel jobs." --run-manual --ui-test-action-max-timeout=350000 --test-launcher-jobs=1 --test-launcher-bot-mode --test-launcher-print-test-stdio=always TBR=phajdan.jr@chromium.org Change-Id: I33f2b4fc54b43ebec8a27c532da17146b42c07cd Reviewed-on: https://chromium-review.googlesource.com/573380 Reviewed-by: Mostyn Bramley-Moore <mostynb@opera.com> Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com> Cr-Commit-Position: refs/heads/master@{#487014} [modify] https://crrev.com/eb12aa53060d9397de49ed5c2e72a0bdf36833e2/base/test/launcher/test_launcher.cc
,
Jul 17 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by most...@opera.com
, Jul 13 2017