New issue
Advanced search Search tips

Issue 741921 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Upstream layout tests for device memory client hints & JS API to web-platform-tests

Project Member Reported by panicker@chromium.org, Jul 12 2017

Issue description

Comment 1 by panicker@google.com, Aug 24 2017

Summary: Upstream layout tests for device memory client hints & JS API to web-platform-tests (was: Upstream layout tests for client hints to web-platform-tests)
Labels: -Pri-3 Pri-2
Fadi, have we made any progress on this?
I have a CL inflight that adds the functionality to the workers, and upstreams the tests.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d591aaa4bb924b5532981301d713be25087e0e33

commit d591aaa4bb924b5532981301d713be25087e0e33
Author: Fadi Meawad <fmeawad@chromium.org>
Date: Mon Jan 08 18:34:16 2018

[deviceMemory] Implement navigator.deviceMemory for workers

The original spec specified that this would also work for workers,
this CL add the deviceMemory functionality to the workers by moving the
deviceMemory getter it its own IDL.

In this CL, the tests are also upstreamed.

Bug:  chromium:758302 , chromium:741921 
Change-Id: I9852d08e5a96172bcacf62a353b81a48e902fa95
Reviewed-on: https://chromium-review.googlesource.com/849512
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527681}
[add] https://crrev.com/d591aaa4bb924b5532981301d713be25087e0e33/third_party/WebKit/LayoutTests/external/wpt/navigator/device-memory.https.any.js
[delete] https://crrev.com/6d25f4059bbfb5c6567f74cc917233f408564634/third_party/WebKit/LayoutTests/fast/dom/navigator-deviceMemory.https-expected.txt
[delete] https://crrev.com/6d25f4059bbfb5c6567f74cc917233f408564634/third_party/WebKit/LayoutTests/fast/dom/navigator-deviceMemory.https.html
[modify] https://crrev.com/d591aaa4bb924b5532981301d713be25087e0e33/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/d591aaa4bb924b5532981301d713be25087e0e33/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/d591aaa4bb924b5532981301d713be25087e0e33/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/d591aaa4bb924b5532981301d713be25087e0e33/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/d591aaa4bb924b5532981301d713be25087e0e33/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/d591aaa4bb924b5532981301d713be25087e0e33/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/d591aaa4bb924b5532981301d713be25087e0e33/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/d591aaa4bb924b5532981301d713be25087e0e33/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/d591aaa4bb924b5532981301d713be25087e0e33/third_party/WebKit/Source/core/frame/BUILD.gn
[modify] https://crrev.com/d591aaa4bb924b5532981301d713be25087e0e33/third_party/WebKit/Source/core/frame/Navigator.cpp
[modify] https://crrev.com/d591aaa4bb924b5532981301d713be25087e0e33/third_party/WebKit/Source/core/frame/Navigator.h
[modify] https://crrev.com/d591aaa4bb924b5532981301d713be25087e0e33/third_party/WebKit/Source/core/frame/Navigator.idl
[add] https://crrev.com/d591aaa4bb924b5532981301d713be25087e0e33/third_party/WebKit/Source/core/frame/NavigatorDeviceMemory.cpp
[add] https://crrev.com/d591aaa4bb924b5532981301d713be25087e0e33/third_party/WebKit/Source/core/frame/NavigatorDeviceMemory.h
[add] https://crrev.com/d591aaa4bb924b5532981301d713be25087e0e33/third_party/WebKit/Source/core/frame/NavigatorDeviceMemory.idl
[modify] https://crrev.com/d591aaa4bb924b5532981301d713be25087e0e33/third_party/WebKit/Source/core/workers/WorkerNavigator.h
[modify] https://crrev.com/d591aaa4bb924b5532981301d713be25087e0e33/third_party/WebKit/Source/core/workers/WorkerNavigator.idl

Comment 6 by maxlg@chromium.org, Apr 23 2018

Is this bug fixed?
Status: Fixed (was: Assigned)
Yes.

Sign in to add a comment