MD Extension: handle error cases for the "pack extensions" dialog. |
|||||
Issue descriptionCurrently user are allowed to click the "pack extension" button in the "pack extension" dialog and get a JS runtime error if the form is empty/invalid. The action button should be disabled and unclickable until form inputs are valid.
,
Jul 12 2017
,
Jul 18 2017
,
Jul 26 2017
renaming the bug to reflect the new approach we decided to take for this issue.
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d06acef1441623726333aa654545d6074032b147 commit d06acef1441623726333aa654545d6074032b147 Author: Scott Chen <scottchen@chromium.org> Date: Wed Aug 02 17:43:26 2017 MD Extension: handle error cases when packing extensions. Currently the Pack Extensions dialog just crashes or silently fails when an error or warning is raised. This CL implements an alert system that is in parity with the old extensions page. Bug: 741900 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6e85b6da179495f20b0c0122a0592607f892d8f9 Reviewed-on: https://chromium-review.googlesource.com/587971 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#491427} [modify] https://crrev.com/d06acef1441623726333aa654545d6074032b147/chrome/app/md_extensions_strings.grdp [modify] https://crrev.com/d06acef1441623726333aa654545d6074032b147/chrome/browser/browser_resources.grd [modify] https://crrev.com/d06acef1441623726333aa654545d6074032b147/chrome/browser/resources/md_extensions/compiled_resources2.gyp [modify] https://crrev.com/d06acef1441623726333aa654545d6074032b147/chrome/browser/resources/md_extensions/pack_dialog.html [modify] https://crrev.com/d06acef1441623726333aa654545d6074032b147/chrome/browser/resources/md_extensions/pack_dialog.js [add] https://crrev.com/d06acef1441623726333aa654545d6074032b147/chrome/browser/resources/md_extensions/pack_dialog_alert.html [add] https://crrev.com/d06acef1441623726333aa654545d6074032b147/chrome/browser/resources/md_extensions/pack_dialog_alert.js [modify] https://crrev.com/d06acef1441623726333aa654545d6074032b147/chrome/browser/resources/md_extensions/service.js [modify] https://crrev.com/d06acef1441623726333aa654545d6074032b147/chrome/browser/ui/webui/extensions/extensions_ui.cc [modify] https://crrev.com/d06acef1441623726333aa654545d6074032b147/chrome/test/data/webui/extensions/cr_extensions_browsertest.js [modify] https://crrev.com/d06acef1441623726333aa654545d6074032b147/chrome/test/data/webui/extensions/extension_pack_dialog_test.js
,
Aug 8 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by scottchen@chromium.org
, Jul 12 2017