New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 741898 link

Starred by 2 users
Status: Fixed
Owner:
liaoyuke@chromium.org
Closed: Jul 2017
Cc:
█ baxley@chromium.org
█ lpromero@chromium.org
█ huangml@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Clean up local helpers that taps NavigationBarDoneButton() in settings menu.

Project Member Reported by liaoyuke@chromium.org, Jul 12 2017 
There are still tests that wraps NavigationBarDoneButton with a local helper function, which is unnecessary, instead, we should call EarlGrey explicitly like following: 

[[EarlGrey selectElementWithMatcher:NavigationBarDoneButton()]
      performAction:grey_tap()];
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fef43018c7fc4fd6ef57d0dd16c8592f25b63d72

commit fef43018c7fc4fd6ef57d0dd16c8592f25b63d72
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Thu Jul 20 23:51:23 2017

Clean up usages of chrome_test_util::NavigationBarDoneButton()

There are still tests that wraps NavigationBarDoneButton with a local
helper function, which is unnecessary, instead, we should call EarlGrey
explicitly like following:

[[EarlGrey selectElementWithMatcher:NavigationBarDoneButton()]
      performAction:grey_tap()];

So, this CL cleans them up.

Bug:  741898 
Change-Id: I74ea738cb1e58b1ee44da57c1dfaf74b7c348405
Reviewed-on: https://chromium-review.googlesource.com/568271
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mihai Sardarescu (OOO) <msarda@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Mike Baxley <baxley@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488490}
[modify] https://crrev.com/fef43018c7fc4fd6ef57d0dd16c8592f25b63d72/ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm
[modify] https://crrev.com/fef43018c7fc4fd6ef57d0dd16c8592f25b63d72/ios/chrome/browser/ui/settings/clear_browsing_data_egtest.mm
[modify] https://crrev.com/fef43018c7fc4fd6ef57d0dd16c8592f25b63d72/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm
[modify] https://crrev.com/fef43018c7fc4fd6ef57d0dd16c8592f25b63d72/ios/chrome/browser/ui/settings/settings_egtest.mm

Comment 2 by liaoyuke@chromium.org, Jul 21 2017

Status: Fixed (was: Started)
►

Sign in to add a comment