New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 741877 link

Starred by 2 users
Status: Fixed
Owner:
█ scottchen@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
Cc:
rdevlin....@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

MD Extension: move duplicated CSS rules into a shared css file.

Project Member Reported by scottchen@chromium.org, Jul 12 2017 
Currently a lot of CSS rules are duplicated across custom elements and pages within md_extensions. We should move those into a shared css file and import it instead, to improve maintainability.

(And I just want to especially call this out - there should be global default font-size/color/line-height styles across the whole md_extensions section).

Comment 1 by scottchen@chromium.org, Jul 12 2017

Description: Show this description

Comment 2 by scottchen@chromium.org, Jul 12 2017

Labels: Proj-MaterialDesign-WebUI

Comment 3 by scottchen@chromium.org, Jul 12 2017

Labels: Pri-2

Comment 4 by scottchen@chromium.org, Jul 17 2017

Status: Started (was: Available)

Comment 5 by scottchen@chromium.org, Jul 17 2017

Owner: scottchen@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a11f133130e4195ab99653be6c2db8af78de2782

commit a11f133130e4195ab99653be6c2db8af78de2782
Author: Scott Chen <scottchen@chromium.org>
Date: Tue Jul 18 03:19:55 2017

MD Extension: have a global font-size and line-height.

This CL consolidates individual "font-size:13px"s and "line-height:20px"s into a
global rule.

Bug:  741877 
Change-Id: Ica1d1498f7f7c7ad11df8f522dd22984230c0f73
Reviewed-on: https://chromium-review.googlesource.com/574672
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487370}
[modify] https://crrev.com/a11f133130e4195ab99653be6c2db8af78de2782/chrome/browser/resources/md_extensions/detail_view.html
[modify] https://crrev.com/a11f133130e4195ab99653be6c2db8af78de2782/chrome/browser/resources/md_extensions/extensions.html
[modify] https://crrev.com/a11f133130e4195ab99653be6c2db8af78de2782/chrome/browser/resources/md_extensions/item.html
[modify] https://crrev.com/a11f133130e4195ab99653be6c2db8af78de2782/chrome/browser/resources/md_extensions/keyboard_shortcuts.html
[modify] https://crrev.com/a11f133130e4195ab99653be6c2db8af78de2782/chrome/browser/resources/md_extensions/load_error.html
[modify] https://crrev.com/a11f133130e4195ab99653be6c2db8af78de2782/chrome/browser/resources/md_extensions/manager.html
[modify] https://crrev.com/a11f133130e4195ab99653be6c2db8af78de2782/chrome/browser/resources/md_extensions/pack_dialog.html
[modify] https://crrev.com/a11f133130e4195ab99653be6c2db8af78de2782/chrome/browser/resources/md_extensions/shortcut_input.html
[modify] https://crrev.com/a11f133130e4195ab99653be6c2db8af78de2782/chrome/browser/resources/md_extensions/sidebar.html
[modify] https://crrev.com/a11f133130e4195ab99653be6c2db8af78de2782/chrome/browser/resources/md_extensions/toolbar.html

Comment 7 by scottchen@chromium.org, Aug 16 2017

Status: Fixed (was: Started)

Comment 8 by dpa...@chromium.org, Mar 12 2018

Components: UI>Browser>ExtensionsManagement
►

Sign in to add a comment