New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 741871 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Write an EarlGrey test for closing background Tabs before their dialogs can be displayed.

Project Member Reported by kkhorimoto@chromium.org, Jul 12 2017

Issue description

go/chromepostmortem466

Lack of test coverage for this feature resulted in a crash that required a refresh release.
 
Labels: ReleaseBlock-Beta
Labels: -Pri-3 Pri-1
Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/580499
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e4c8bac4245b18dc3fa8954a945b996a0e59c92

commit 7e4c8bac4245b18dc3fa8954a945b996a0e59c92
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Tue Jul 25 01:04:19 2017

Added tests for closing tabs in tab switcher while it has queued dialog.

Due to the vastly different implementations of the iPhone and iPad
tab switchers, the test needs to be added to both egtest files.  In the
new architecture when the tab switcher implementations are consolidated,
the stack view version of this test can be deleted.

Bug:  741871 
Change-Id: Id00735ab51b70c9d7bd6d057d3eb321d7d63af35
Reviewed-on: https://chromium-review.googlesource.com/580499
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Ed Chin <edchin@chromium.org>
Reviewed-by: Mike Baxley <baxley@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489170}
[modify] https://crrev.com/7e4c8bac4245b18dc3fa8954a945b996a0e59c92/ios/chrome/browser/ui/stack_view/BUILD.gn
[modify] https://crrev.com/7e4c8bac4245b18dc3fa8954a945b996a0e59c92/ios/chrome/browser/ui/stack_view/stack_view_egtest.mm
[modify] https://crrev.com/7e4c8bac4245b18dc3fa8954a945b996a0e59c92/ios/chrome/browser/ui/tab_switcher/BUILD.gn
[modify] https://crrev.com/7e4c8bac4245b18dc3fa8954a945b996a0e59c92/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller_egtest.mm
[modify] https://crrev.com/7e4c8bac4245b18dc3fa8954a945b996a0e59c92/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.h
[modify] https://crrev.com/7e4c8bac4245b18dc3fa8954a945b996a0e59c92/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm
[modify] https://crrev.com/7e4c8bac4245b18dc3fa8954a945b996a0e59c92/ios/web/public/test/http_server/BUILD.gn
[add] https://crrev.com/7e4c8bac4245b18dc3fa8954a945b996a0e59c92/ios/web/public/test/http_server/blank_page_response_provider.h
[add] https://crrev.com/7e4c8bac4245b18dc3fa8954a945b996a0e59c92/ios/web/public/test/http_server/blank_page_response_provider.mm

Labels: Merge-Request-61
Status: Fixed (was: Started)

Comment 6 by cma...@chromium.org, Jul 25 2017

Labels: -Merge-Request-61 Merge-Approved-61
Thanks for writing this test Kurt! 
Project Member

Comment 7 by sheriffbot@chromium.org, Jul 31 2017

Cc: cma...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by sheriffbot@chromium.org, Aug 4 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 8 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75fd5240034c5d7a47e17d6b1dd3f1d9ab2582b2

commit 75fd5240034c5d7a47e17d6b1dd3f1d9ab2582b2
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Tue Aug 08 23:43:26 2017

Added tests for closing tabs in tab switcher while it has queued dialog.

Due to the vastly different implementations of the iPhone and iPad
tab switchers, the test needs to be added to both egtest files.  In the
new architecture when the tab switcher implementations are consolidated,
the stack view version of this test can be deleted.

TBR=kkhorimoto@chromium.org

(cherry picked from commit 7e4c8bac4245b18dc3fa8954a945b996a0e59c92)

Bug:  741871 
Change-Id: Id00735ab51b70c9d7bd6d057d3eb321d7d63af35
Reviewed-on: https://chromium-review.googlesource.com/580499
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Ed Chin <edchin@chromium.org>
Reviewed-by: Mike Baxley <baxley@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489170}
Reviewed-on: https://chromium-review.googlesource.com/607450
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#393}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/75fd5240034c5d7a47e17d6b1dd3f1d9ab2582b2/ios/chrome/browser/ui/stack_view/BUILD.gn
[modify] https://crrev.com/75fd5240034c5d7a47e17d6b1dd3f1d9ab2582b2/ios/chrome/browser/ui/stack_view/stack_view_egtest.mm
[modify] https://crrev.com/75fd5240034c5d7a47e17d6b1dd3f1d9ab2582b2/ios/chrome/browser/ui/tab_switcher/BUILD.gn
[modify] https://crrev.com/75fd5240034c5d7a47e17d6b1dd3f1d9ab2582b2/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller_egtest.mm
[modify] https://crrev.com/75fd5240034c5d7a47e17d6b1dd3f1d9ab2582b2/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.h
[modify] https://crrev.com/75fd5240034c5d7a47e17d6b1dd3f1d9ab2582b2/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm
[modify] https://crrev.com/75fd5240034c5d7a47e17d6b1dd3f1d9ab2582b2/ios/web/public/test/http_server/BUILD.gn
[add] https://crrev.com/75fd5240034c5d7a47e17d6b1dd3f1d9ab2582b2/ios/web/public/test/http_server/blank_page_response_provider.h
[add] https://crrev.com/75fd5240034c5d7a47e17d6b1dd3f1d9ab2582b2/ios/web/public/test/http_server/blank_page_response_provider.mm

Sign in to add a comment