New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 741845 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

Add support for EGL_ANDROID_native_fence_sync on AMD GPUs

Project Member Reported by dbehr@chromium.org, Jul 12 2017

Issue description

Mesa framework is already there ... so "just" Mesa driver and kernel parts are missing.
 

Comment 1 by dbehr@chromium.org, Jul 12 2017

Cc: marc...@chromium.org chadversary@chromium.org reve...@chromium.org hoegsberg@chromium.org

Comment 2 by dbehr@chromium.org, Aug 22 2017

Cc: ddavenp...@chromium.org
Cc: deepak.s...@amd.com
What kind of failures should we expect with this missing?
Cc: teravest@chromium.org

Comment 6 by deepak.s...@amd.com, Oct 16 2017

how to test this in chrome, Is there any test case ?

Comment 7 by dbehr@chromium.org, Nov 28 2017

per reveman@ Chrome is landing changes to use this and it should use it automatically if the extension exists. Also the simple ozone test that does buffer flipping should use it when available.

Comment 8 by deepak.s...@amd.com, Nov 29 2017

Support for EGL_ANDROID_native_fence_sync in amdgpu is already present along with libdrm/mesa changes. Was not sure how to test it or if any particular test is present in chrome for it.
Have the necessary changes to use this landed in Chrome? Is there a way to verify that the path that uses this extension is getting exercised?
Not yet.

RFC CL here:
https://chromium-review.googlesource.com/c/chromium/src/+/857499

that probably doesn't work yet but it's on the right track so I'm expecting it to land in some form soon.
Thanks for the update. In the meantime, is there another way that EGL_ANDROID_native_fence_sync can be tested? Are there any other tests or code paths that would exercise this?
The rects wayland client test uses this extension when available: https://cs.chromium.org/chromium/src/components/exo/wayland/clients/rects.cc

We'll update that code to pass the fence fd to chrome eventually but maybe updating it to use libsync to wait on the fence fd is a good first step.
ddavenport said:
> Thanks for the update. In the meantime, is there another way that EGL_ANDROID_native_fence_sync can be tested? Are there any other tests or code paths that would exercise this?

If you're willing to dive into ARC++, you could "test" EGL_ANDROID_native_fence_sync by running any app and strategically inserting logcat messages into Mesa.
Components: Platform>Apps>ARC OS>Kernel>Graphics
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".

Sign in to add a comment