New issue
Advanced search Search tips

Issue 741842 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[CRD iOS] Adding the first launch view

Project Member Reported by yuweih@chromium.org, Jul 12 2017

Issue description

Rather than keep popping up the sign-in modal if the user isn't signed in, we should implement a view to ask the user to sign in.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddce5e3b48bc9388e4e335ab61ca61da3c82d40d

commit ddce5e3b48bc9388e4e335ab61ca61da3c82d40d
Author: Yuwei Huang <yuweih@chromium.org>
Date: Thu Jul 13 22:37:59 2017

[CRD iOS] Adding the first launch view

Adding a first launch view to be shown when the user is not signed in.
The view will also kick in if the user signs out.

Bug:  741842 
Change-Id: Ib80df93df428f9923834573b19f10cc4f973f42e
Reviewed-on: https://chromium-review.googlesource.com/568858
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Scott Nichols <nicholss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486496}
[modify] https://crrev.com/ddce5e3b48bc9388e4e335ab61ca61da3c82d40d/remoting/ios/app/BUILD.gn
[modify] https://crrev.com/ddce5e3b48bc9388e4e335ab61ca61da3c82d40d/remoting/ios/app/app_delegate.h
[modify] https://crrev.com/ddce5e3b48bc9388e4e335ab61ca61da3c82d40d/remoting/ios/app/app_delegate.mm
[add] https://crrev.com/ddce5e3b48bc9388e4e335ab61ca61da3c82d40d/remoting/ios/app/first_launch_view_controller.h
[add] https://crrev.com/ddce5e3b48bc9388e4e335ab61ca61da3c82d40d/remoting/ios/app/first_launch_view_controller.mm
[add] https://crrev.com/ddce5e3b48bc9388e4e335ab61ca61da3c82d40d/remoting/ios/app/first_launch_view_presenter.h
[add] https://crrev.com/ddce5e3b48bc9388e4e335ab61ca61da3c82d40d/remoting/ios/app/first_launch_view_presenter.mm
[modify] https://crrev.com/ddce5e3b48bc9388e4e335ab61ca61da3c82d40d/remoting/ios/app/remoting_theme.h
[modify] https://crrev.com/ddce5e3b48bc9388e4e335ab61ca61da3c82d40d/remoting/ios/app/remoting_theme.mm
[modify] https://crrev.com/ddce5e3b48bc9388e4e335ab61ca61da3c82d40d/remoting/ios/app/remoting_view_controller.mm

Comment 2 by yuweih@chromium.org, Jul 14 2017

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified in 63.0.3220.0

Sign in to add a comment