ScrollableArea::ScrollIntoView should return the amount it needs to scroll |
|
Issue descriptionCurrently, ScrollableArea::ScrollIntoView returns the new location of the input recrt relative once again to the document. This return value adds difficulty of calculating the next rect_to_scroll if the ScrollableArea is LocalFrameView. Instead, it should return the target offset it needs to scroll to(i.e. the expose rect)
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7834579b7d67fc897ee10a21984c61bf8b35b08a commit 7834579b7d67fc897ee10a21984c61bf8b35b08a Author: David Bokan <bokan@chromium.org> Date: Tue Oct 30 15:48:36 2018 Remove unused pre-root-layer-scrolling code. PendingOffsetToScroll was previously used to store where the layout box was being scrolled to. There was a pre-RLS fixup to this value but it's no longer set to anything other than its initial value so this CL removes the entire value. Bug: 823365 ,741830 Change-Id: I4d4090b629ad614bf691ea6360240fea7d43982d Reviewed-on: https://chromium-review.googlesource.com/c/1305818 Reviewed-by: Sandra Sun <sunyunjia@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#603915} [modify] https://crrev.com/7834579b7d67fc897ee10a21984c61bf8b35b08a/third_party/blink/renderer/core/layout/layout_box.cc [modify] https://crrev.com/7834579b7d67fc897ee10a21984c61bf8b35b08a/third_party/blink/renderer/core/layout/layout_box.h |
|
►
Sign in to add a comment |
|
Comment 1 by dtapu...@chromium.org
, Nov 1 2017