New issue
Advanced search Search tips

Issue 741829 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 743071
issue 743100



Sign in to add a comment

New gunk in run_suite output breaks buildbot page reporting

Reported by jrbarnette@chromium.org, Jul 12 2017

Issue description

For an example of the problem, compare these two canary
build pages:
    https://uberchromegw.corp.google.com/i/chromeos/builders/kevin-release/builds/1306
    https://uberchromegw.corp.google.com/i/chromeos/builders/kevin-release/builds/1307

Both failed in similar ways.  However, the failures aren't
reported quite the same.

Build #1306 (what we want to see):
  * stdio [stdout]
  * Link to suite
  * [Auto-Bug]: platform_FilePerms: retry_count: 2, FAIL: Found 3 permission errors, 75 reports
  * [Test-Logs]: platform_FilePerms: retry_count: 2, FAIL: Found 3 permission errors
  * [Flake-Dashboard]: platform_FilePerms
  * Suite details

Build #1307 (the bug in action):
  * stdio [stdout]
  * Suite details

In the second case, information about the failing test is omitted.

The root cause would appear to be new gunk added into the run_suite output.
Refer to this log file:
    https://uberchromegw.corp.google.com/i/chromeos/builders/kevin-release/builds/1307/steps/HWTest%20%5Bbvt-inline%5D/logs/stdio

That log shows lines like the below:
====
INFO:root:
 07-11-2017 [22:03:13] Output below this line is for buildbot consumption:
INFO:root:@@@STEP_LINK@[Test-Logs]: security_ASLR: retry_count: 1, GOOD: completed successfully@http://cautotest/tko/retrieve_logs.cgi?job=/results/128132883-chromeos-test/@@@
INFO:root:@@@STEP_LINK@[Flake-Dashboard]: security_ASLR@https://wmatrix.googleplex.com/retry_teststats/?days_back=30&tests=security_ASLR@@@
INFO:root:@@@STEP_LINK@[Auto-Bug]: platform_FilePerms: retry_count: 2, FAIL: Found 3 permission errors, 87 reports@https://code.google.com/p/chromium/issues/detail?id=615389@@@
INFO:root:@@@STEP_LINK@[Test-Logs]: platform_FilePerms: retry_count: 2, FAIL: Found 3 permission errors@http://cautotest/tko/retrieve_logs.cgi?job=/results/128150334-chromeos-test/@@@
INFO:root:@@@STEP_LINK@[Flake-Dashboard]: platform_FilePerms@https://wmatrix.googleplex.com/retry_teststats/?days_back=30&tests=platform_FilePerms@@@
INFO:root:Will return from run_suite with status: ERROR
====

The "INFO:root:" prefix is scattered randomly across many (but not all)
log lines.  This is new.  It shouldn't be there.  Its presence is likely
screwing up the buildbot log parsing that would otherwise provide the links.

 
Owner: xixuan@chromium.org
Status: Assigned (was: Untriaged)
Five'll get ya ten that this is the culprit:
    https://chromium-review.googlesource.com/#/c/564059/

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/99eba0b5cd171c23b16550f202146f3a692c4571

commit 99eba0b5cd171c23b16550f202146f3a692c4571
Author: xixuan <xixuan@chromium.org>
Date: Thu Jul 13 21:56:23 2017

autotest: Set other logging handlers when require_logfile is not set.

BUG= chromium:741829 
TEST=Ran ./site_utils/run_suite.py --build *** --require_logfile vs
./site_utils/run_suite.py --build *** vs
./site_utils/run_suite.py --require_logfile.

Change-Id: I0c7f329508de2dfcca245e6442a3d50f8b6c3334
Reviewed-on: https://chromium-review.googlesource.com/569062
Commit-Queue: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Trybot-Ready: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@google.com>

[modify] https://crrev.com/99eba0b5cd171c23b16550f202146f3a692c4571/site_utils/run_suite.py

Blockedon: 743077 743071
Blockedon: -743077
Blockedon: 743100

Comment 6 by xixuan@chromium.org, Aug 17 2017

Status: Verified (was: Assigned)

Sign in to add a comment