☂ Reduce time it takes to enter VR |
|||
Issue descriptionOur VR Entry is probably more asynchronous than it needs to be, and we do a bunch of work in onResume that we don't necessarily need to. We can do better.
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d47c8c334160e9ebd34d575842a87acf42fa96e commit 1d47c8c334160e9ebd34d575842a87acf42fa96e Author: Michael Thiessen <mthiesse@chromium.org> Date: Thu Jul 13 15:35:57 2017 VR: Don't unnecessarily update VR Support Level Updating VR Support Level takes anywhere from 3-10ms on Pixel phones. In most cases we can skip this work. Bug: 741823 Change-Id: I8747fb19aea00444ceef1fb245f869b022a67e61 Reviewed-on: https://chromium-review.googlesource.com/568811 Reviewed-by: Biao She <bshe@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#486389} [modify] https://crrev.com/1d47c8c334160e9ebd34d575842a87acf42fa96e/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
,
Sep 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7877850aacaead4be004d301b876ac556a48a7ab commit 7877850aacaead4be004d301b876ac556a48a7ab Author: Michael Thiessen <mthiesse@chromium.org> Date: Thu Sep 07 23:13:42 2017 VR: Don't start rendering until the activity is visible. This makes starting VR after the DON flow ~150ms faster on release builds because we're not doing a bunch of work drawing frames that won't be visible. This 150ms savings is measured in the time between onResume and OnWindowFocusChanged, which dropped from ~250ms to ~100ms on a Pixel XL. Bug: 763032 , 741823 Change-Id: Ia915a46c72c27cfe838e0d6b8d0336c566d6f413 Reviewed-on: https://chromium-review.googlesource.com/655774 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#500426} [modify] https://crrev.com/7877850aacaead4be004d301b876ac556a48a7ab/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/7877850aacaead4be004d301b876ac556a48a7ab/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/7877850aacaead4be004d301b876ac556a48a7ab/chrome/browser/android/vr_shell/vr_shell_gl.cc [modify] https://crrev.com/7877850aacaead4be004d301b876ac556a48a7ab/chrome/browser/android/vr_shell/vr_shell_gl.h
,
Sep 7 2017
Hi Michael, Do we have tracing to measure the time to enter VR? If yes, we can set up continuous perf test to track it.
,
Sep 8 2017
If we have tracing events for the Activity onStart and webVR frame submission we could measure the time between the two. However, this would have to be done on bots that don't skip the DON flow. With DON skipping on, we could measure the time between a page calling requestPresent and submitting its first frame as well.
,
Jun 26 2018
,
Jul 4
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jul 13 2017