New issue
Advanced search Search tips

Issue 741812 link

Starred by 2 users
Status: Verified
Owner:
cmt...@chromium.org
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

[bisection tool] Full bisection test does not work properly with ChromeOS wrapper

Project Member Reported by cmt...@chromium.org, Jul 12 2017 
The full bisection test was written to work with the Android compiler wrapper; using it with the ChromeOS compiler wrapper causes it to break (among other things Android compiler wrapper defines BISECT_DIR, but ChromeOS one does not..._
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/toolchain-utils/+/c600e4e6f2ffc7459a3a56b0bcb3d3f6842b4fbe

commit c600e4e6f2ffc7459a3a56b0bcb3d3f6842b4fbe
Author: Caroline Tice <cmtice@google.com>
Date: Thu Jul 13 17:48:37 2017

[bisect tool] Fix full test to work with ChromeOS as well as Android.

The run_bisect_test.py script worked well for Android but had a few
hiccups for testing the ChromeOS compiler wrapper.  This CL fixes that.

BUG= chromium:741812 
TEST=Ran test successfully outside the chroot with Android compiler
wrapper; ran test succesfully inside chroot with ChromeOS compiler
wrapper.

Change-Id: Id5f737932064497e0dfaff9ba3ac53b4c1c87373
Reviewed-on: https://chromium-review.googlesource.com/568407
Commit-Ready: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>

[add] https://crrev.com/c600e4e6f2ffc7459a3a56b0bcb3d3f6842b4fbe/binary_search_tool/full_bisect_test/chromeos_build.sh
[modify] https://crrev.com/c600e4e6f2ffc7459a3a56b0bcb3d3f6842b4fbe/binary_search_tool/full_bisect_test/switch_to_good.sh
[modify] https://crrev.com/c600e4e6f2ffc7459a3a56b0bcb3d3f6842b4fbe/binary_search_tool/full_bisect_test/switch_to_bad.sh
[modify] https://crrev.com/c600e4e6f2ffc7459a3a56b0bcb3d3f6842b4fbe/binary_search_tool/run_bisect_test.py
[modify] https://crrev.com/c600e4e6f2ffc7459a3a56b0bcb3d3f6842b4fbe/binary_search_tool/README.testing

Comment 2 by cmt...@chromium.org, Jul 13 2017

Status: Fixed (was: Assigned)

Comment 3 by abod...@chromium.org, Aug 3 2017

Status: Verified (was: Fixed)
Closing. Please reopen it if its not fixed. Thanks!
►

Sign in to add a comment