New issue
Advanced search Search tips

Issue 741802 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Desktop session should be stopped if IPC channel is down

Project Member Reported by zijiehe@chromium.org, Jul 12 2017

Issue description

The logic in DesktopSessionProxy::OnChannelError() (https://cs.chromium.org/chromium/src/remoting/host/desktop_session_proxy.cc?rcl=6edd49c516047daa73d069c600bf9b2a09493bb7&l=210) looks suspicious. AFAIK, IPC channel cannot recover automatically (e.g. https://cs.chromium.org/chromium/src/mojo/public/cpp/bindings/lib/interface_endpoint_client.cc?rcl=7fe59e8349a6e6e6a2511277108acdbeeaa83b6f&l=311). But once the IPC channel is down, we do not shutdown the ClientSession, instead temporary error will be returned (e.g. https://cs.chromium.org/chromium/src/remoting/host/desktop_session_proxy.cc?rcl=7fe59e8349a6e6e6a2511277108acdbeeaa83b6f&l=269).

A workable solution is to return permanent error from DesktopCapturer once the channel error happened.

This issue impacts Windows only.
 
Owner: zijiehe@chromium.org
Status: Assigned (was: Untriaged)
Owner: ----
Status: Untriaged (was: Assigned)
Status: Available (was: Untriaged)
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 17

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment