webkit_tests virtual/threaded/animations/font-size-using-ems.html is flaky on WebKit Mac10.11 (dbg) and WebKit Win7 (dbg) |
||||
Issue descriptionwebkit_tests virtual/threaded/animations/font-size-using-ems.html has failed in the following five builds over the past day: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/9470 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/9475 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/9478 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/9479 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/9481 This test was recently enabled in a985cd3b4900 (https://codereview.chromium.org/2974853002) after having been disabled. The commit message states: > - Enables a disabled but passing test (font-size-using-ems) This is not true, the test is failing on this bot. I will disable the test.
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e3594c49d69bd94a4227032f1c5ad299739e5c6 commit 0e3594c49d69bd94a4227032f1c5ad299739e5c6 Author: Mark Mentovai <mark@chromium.org> Date: Wed Jul 12 19:00:00 2017 blink: Disable flaky font-size-using-ems test This test is flaky on WebKit Mac10.11 (dbg). It was recently enabled in a985cd3b4900 after having been disabled. Bug: 741795 Change-Id: Ib09d44f8b087b3d894aba0ae72dad1b778934822 Tbr: suzyh@chromium.org NoTry: true NoPresubmit: true Reviewed-on: https://chromium-review.googlesource.com/568799 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#486042} [rename] https://crrev.com/0e3594c49d69bd94a4227032f1c5ad299739e5c6/third_party/WebKit/LayoutTests/animations/font-size-using-ems.html-disabled
,
Jul 12 2017
Flaky on WebKit Win7 (dbg) also.
,
Jul 12 2017
,
Jul 13 2017
Ah, thanks for pointing out that it is not completely passing! I think it would be preferable to add a TestExpectations entry for the flake rather than completely disabling the test by renaming it (since it's so easy to not realise that there's a disabled test), but ericwilligers has an idea how to rewrite this to not be flaky, so passing it over to him.
,
Jul 13 2017
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/385810ad3059b1b51d7fbdc513876e49dc38849d commit 385810ad3059b1b51d7fbdc513876e49dc38849d Author: Eric Willigers <ericwilligers@chromium.org> Date: Thu Jul 13 05:33:27 2017 CSS Animations: Fix flaky font-size-using-ems.html The test font-size-using-ems.html needlessly used setTimeout in an attempt to capture a snapshot of a property value while the animation is in progress. We now use a paused animation with negative start delay to avoid flakiness. The test can now safely be enabled. BUG= 741795 Change-Id: I2703e48f67608f9526293160aecd5e45dfc89645 Reviewed-on: https://chromium-review.googlesource.com/569543 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#486280} [delete] https://crrev.com/dba107b0d7c488b023c00a39483f36911e518b71/third_party/WebKit/LayoutTests/animations/font-size-using-ems-expected.txt [add] https://crrev.com/385810ad3059b1b51d7fbdc513876e49dc38849d/third_party/WebKit/LayoutTests/animations/font-size-using-ems.html [delete] https://crrev.com/dba107b0d7c488b023c00a39483f36911e518b71/third_party/WebKit/LayoutTests/animations/font-size-using-ems.html-disabled
,
Jul 13 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mark@chromium.org
, Jul 12 2017