Move DiscardableImageMap to the RasterSource |
||
Issue descriptionCurrently, the DiscardableImageMap lives on the DisplayItemList. However, it's never used except in raster source. That is, all the callers access it via the raster source (except maybe tests), and it just forwards the calls to DisplayItemList. We should hoist the DiscardableImageMap to just live on the RasterSource.
,
Jul 17 2017
RecordingSource::FinishDisplayItemListUpdate will also call DisplayItemList::GenerateDiscardableImagesMetadata to generate DiscardableImageMap.
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c08d90b4166cc66fa8398a87318eb8955967de15 commit c08d90b4166cc66fa8398a87318eb8955967de15 Author: Vladimir Levin <vmpstr@chromium.org> Date: Tue Jul 18 19:03:59 2017 cc: Refactor discardable image gathering to reduce plumbing. This patch consolidates a few discardable image related work into fewer classes in cc. Specifically, it moves all of the generation code into discardable image map. It also removes display item list functionality and just exposes discardable image map from there, since most of those functions were pass-through. R=enne@chromium.org, khushalsagar@chromium.org Bug: 741775 Change-Id: I483d4544f35356465c09f9084d9a0ec3ae0a9029 Reviewed-on: https://chromium-review.googlesource.com/575347 Commit-Queue: Vladimir Levin <vmpstr@chromium.org> Reviewed-by: Khushal <khushalsagar@chromium.org> Reviewed-by: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#487546} [modify] https://crrev.com/c08d90b4166cc66fa8398a87318eb8955967de15/cc/paint/BUILD.gn [modify] https://crrev.com/c08d90b4166cc66fa8398a87318eb8955967de15/cc/paint/discardable_image_map.cc [modify] https://crrev.com/c08d90b4166cc66fa8398a87318eb8955967de15/cc/paint/discardable_image_map.h [modify] https://crrev.com/c08d90b4166cc66fa8398a87318eb8955967de15/cc/paint/discardable_image_map_unittest.cc [delete] https://crrev.com/39345e3f3f49e7cc025fc58d65dd5a2933dda00a/cc/paint/discardable_image_store.cc [delete] https://crrev.com/39345e3f3f49e7cc025fc58d65dd5a2933dda00a/cc/paint/discardable_image_store.h [modify] https://crrev.com/c08d90b4166cc66fa8398a87318eb8955967de15/cc/paint/display_item_list.cc [modify] https://crrev.com/c08d90b4166cc66fa8398a87318eb8955967de15/cc/paint/display_item_list.h [modify] https://crrev.com/c08d90b4166cc66fa8398a87318eb8955967de15/cc/raster/raster_source.cc
,
Jul 18 2017
I think we've decided to keep the discardable map where it is, with the cleanup in #3 it should be pretty clean now. |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jul 13 2017