Issue metadata
Sign in to add a comment
|
66.3% regression in loading.desktop at 484779:484843 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jul 12 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8974256353391049824
,
Jul 12 2017
=== Auto-CCing suspected CL author rch@chromium.org === Hi rch@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : rch Commit : d6e1cab1edf5f432d2ce09ff8ee34fe14abaff5a Date : Fri Jul 07 03:59:30 2017 Subject: Enable QUIC v39 by default. Bisect Details Configuration: winx64intel_perf_bisect Benchmark : loading.desktop Metric : timeToFirstMeaningfulPaint_avg/pcv1-warm/Pantip Change : 63.57% | 490.478833333 -> 802.2575 Revision Result N chromium@484778 490.479 +- 11.7297 6 good chromium@484811 486.416 +- 9.34123 6 good chromium@484819 487.524 +- 10.3523 6 good chromium@484823 484.647 +- 6.56154 6 good chromium@484825 486.677 +- 6.57639 6 good chromium@484826 801.602 +- 13.7283 6 bad <-- chromium@484827 800.057 +- 5.4807 6 bad chromium@484843 802.257 +- 7.90196 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=Pantip loading.desktop More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8974256353391049824 For feedback, file a bug with component Speed>Bisection
,
Jul 12 2017
I don't think there's any chance that this CL caused the regression, but I guess it's possible? I'd be quite surprised if these tests actually used QUIC. Where could I get more information on the details of the test?
,
Jul 12 2017
Issue 741680 has been merged into this issue.
,
Jul 12 2017
Pretty sure it's a bad bisect from a noisy test. Most of the tests use WebPageReplay locally with no QUIC (or even HTTP/2) support.
,
Jul 17 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8973828812422214928
,
Jul 17 2017
The graphs are noisy but the regression is significantly above the level of noise. Lets try again and see what they find.
,
Jul 17 2017
=== BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : rch Commit : d6e1cab1edf5f432d2ce09ff8ee34fe14abaff5a Date : Fri Jul 07 03:59:30 2017 Subject: Enable QUIC v39 by default. Bisect Details Configuration: winx64_high_dpi_perf_bisect Benchmark : loading.desktop Metric : timeToFirstMeaningfulPaint_avg/pcv1-warm/MLB Change : 114.05% | 985.535777781 -> 1886.68511111 Revision Result N chromium@484780 985.536 +- 949.028 9 good chromium@484818 1187.31 +- 1351.38 9 good chromium@484823 1326.88 +- 1017.78 6 good chromium@484825 1155.84 +- 873.692 6 good chromium@484826 1891.35 +- 611.385 9 bad <-- chromium@484828 1904.1 +- 425.757 14 bad chromium@484837 1803.8 +- 942.075 14 bad chromium@484855 1886.69 +- 736.962 9 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=MLB loading.desktop More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8973828812422214928 For feedback, file a bug with component Speed>Bisection
,
Sep 14 2017
+xunjieli on this really old bug. Helen, do you think this is worth investigating further? I'm not clear how a quic change could have affected old WPR. Adding test owner in case we decide to wontfix.
,
Sep 14 2017
I agree that this looks odd. The QUIC version bump shouldn't affect the loading metrics because QUIC paths weren't covered by WPR. Let's wontFix this. kouhei@: please re-open if further investigation is needed. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jul 12 2017