Issue metadata
Sign in to add a comment
|
1.5%-10.7% regression in system_health.memory_mobile at 484555:484718 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jul 12 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8974256421765033872
,
Jul 14 2017
=== BISECT JOB RESULTS === Bisect was unable to run to completion Error: TIMEOUT The bisect was able to narrow the range, you can try running with: good_revision: 661b99fc181c9ef15a707e72f1ed15d2b35079b7 bad_revision : 0972c74b68f73edc01a5553243ca26b8c723a9e2 If failures persist contact the team (see below) and report the error. Bisect Details Configuration: android_webview_nexus6_aosp_perf_bisect Benchmark : system_health.memory_mobile Metric : memory:webview:all_processes:reported_by_chrome:v8:effective_size_avg/background_social/background_social_facebook Change : 9.82% | 2062896.0 -> 2265500.0 Revision Result N chromium@484588 2062896 +- 0.0 6 good chromium@484605 2062896 +- 0.0 6 good chromium@484613 2062896 +- 0.0 6 good chromium@484621 2265425 +- 204.483 6 bad chromium@484653 2265425 +- 204.483 6 bad chromium@484718 2265500 +- 274.343 6 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=background.social.facebook system_health.memory_mobile More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8974256421765033872 For feedback, file a bug with component Speed>Bisection
,
Aug 21 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8970629491400197168
,
Aug 22 2017
=== Auto-CCing suspected CL author bmeurer@chromium.org === Hi bmeurer@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Benedikt Meurer Commit : b9ee0657c6a0b7504d8bf3630e41923d5a72c71f Date : Thu Jul 06 11:55:14 2017 Subject: [builtins] Unified C++ implementation of Map and Set iterators. Bisect Details Configuration: android_webview_nexus6_aosp_perf_bisect Benchmark : system_health.memory_mobile Metric : memory:webview:all_processes:reported_by_chrome:v8:effective_size_avg/background_social/background_social_facebook Change : 9.82% | 2062896.0 -> 2265462.66667 Revision Result N chromium@484613 2062896 +- 0.0 6 good chromium@484617 2062896 +- 0.0 6 good chromium@484618 2062896 +- 0.0 6 good chromium@484618,v8@124ff5322d 2062896 +- 0.0 6 good chromium@484618,v8@b9ee0657c6 2265425 +- 204.483 6 bad <-- chromium@484618,v8@b520c6ed5e 2265500 +- 274.343 6 bad chromium@484619 2265463 +- 258.653 6 bad chromium@484621 2265463 +- 258.653 6 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=background.social.facebook system_health.memory_mobile More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8970629491400197168 For feedback, file a bug with component Speed>Bisection
,
Aug 23 2017
Issue 740218 has been merged into this issue.
,
Sep 21 2017
bmeurer: ping? bisect is reproducing over 200kib memory regression. Cc-ing test owner perezju to help with priority.
,
Sep 21 2017
That C++ implementation of Map/Set iterators doesn't even exist anymore. By the end of July it was fully ported to the CodeStubAssembler. 200KB sounds like another instance of random CL hitting code space limit. There doesn't seem to be anything concrete about my CL, unless I'm missing something obvious. CC'd memory sheriffs.
,
Sep 22 2017
Scanning through the alerts in: https://chromeperf.appspot.com/group_report?bug_id=741727 The largest ones are around ~0.5MiB, but seem to have recovered recently. And if the code in question no longer even exists, I think it's fine to WontFix. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jul 12 2017