New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 741713 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Not on Chrome anymore
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Sanitize Suggestions test utilities and fakes

Project Member Reported by dgn@chromium.org, Jul 12 2017

Issue description

So far the test utilities we built for the suggestions were made as we go following strict requirements of the tests being written. As we added more, they got bigger and with weirder APIs, sometimes duplicating code.

For example we have multiple ways to create dummy suggestions. We mix mocks and fakes for uiDelegate and SuggestionsSource, relying on Mockito or utility methods to set them up in similar ways.

We probably could clean it up by going from the interface specification, implementing an alternative to the native code properly and exposing straightforward ways to control their internal data.
 

Comment 1 by fi...@chromium.org, Jul 21 2017

Labels: -Type-Bug zine-triaged Type-Feature

Comment 2 by fi...@chromium.org, Jan 12 2018

Status: WontFix (was: Assigned)

Sign in to add a comment