All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=741697

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=5233a9119db485c1dfdf6c714977fee5558ef5973beb1bb79a71b2246e02b001


Bot(s) for this bug's original alert(s):

android-nexus5X
android-nexus6
android-nexus7v2

Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8974258157759638496

=== Auto-CCing suspected CL author ccameron@chromium.org ===

Hi ccameron@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Christopher Cameron
  Commit : 77e966647f6b495fe44772086c709528c711fc6e
  Date   : Mon Jul 10 17:45:28 2017
  Subject: Make SkImage_Lazy::onMakeColorSpace return a SkImage_Lazy

Bisect Details
  Configuration: android_nexus5X_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:skia:effective_size_avg/load_games/load_games_bubbles
  Change       : 277.80% | 33843460.0 -> 127860846.667

Revision                             Result                     N
chromium@485436                      33843460 +- 0.0            6      good
chromium@485477                      33843460 +- 0.0            6      good
chromium@485488                      34985717 +- 6256397        6      good
chromium@485491                      33843460 +- 0.0            6      good
chromium@485491,skia@9f772a44fe      34985717 +- 6256397        6      good
chromium@485491,skia@62ae664e74      33843460 +- 0.0            6      good
chromium@485491,skia@77e966647f      125474616 +- 8618505       6      bad       <--
chromium@485491,skia@d8ddf1bbb4      126413438 +- 5836278       6      bad
chromium@485492                      123175555 +- 17666384      6      bad
chromium@485493                      121890564 +- 32597084      6      bad
chromium@485498                      124230642 +- 8671676       6      bad
chromium@485518                      127860847 +- 557129        6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.games.bubbles system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8974258157759638496


For feedback, file a bug with component Speed>Bisection

Umm, that's really weird. Cause, like, that change reduced memory substantially in that exact same test on other bots. I guess I can try to run locally...

 Issue 741797  has been merged into this issue.

 Issue 741797  has been merged into this issue.

This patch also is causing bazillions of OOMs, according to issue 741607.

While the patch should be saving memory, it may be that creating new uniqueIDs for the same makeColorSpace instances of a SkImage_Lazy. My test device is a brick and I'm taking it to MTV tomorrow to be de-bricked. I'll try reproducing the issue when I get back, unless any other theories come up.

 Issue 742341  has been merged into this issue.

I was hoping to close this bug, but many of these tests haven't been run in several days, for instance...
https://chromeperf.appspot.com/report?sid=ab3a3ba50372c268341cbe5d8c3c34197e1098353b09c107cd80f7c26d991d27&start_rev=482149&end_rev=486073

The only one that I found that has recent data has recovered
https://chromeperf.appspot.com/report?sid=2738a2acaa40f5613c7bdc396872824d4cc9540e978da53af1f873321728c4c2&rev=485535

I'd like to close, but I'd like the data to get in first.

Ned, any thoughts on when we'll get data back in?

These have all recovered now (due to https://skia-review.googlesource.com/23287)

I think we have another memory graph that has not recovered related to this change: https://chromeperf.appspot.com/group_report?bug_id=741747

Issue 741747 has been merged into this issue.

Re #13: With a bit more context, these metrics are now back to their "baseline" levels.

Take a look at the graph going back to mid-June

We have an improvement at
https://chromium.googlesource.com/chromium/src/+log/3fadc6c1ca09861ec2e100cc4fe9354074645a4f%5E..eb576e6c660bc1ce8e7aaf93bfab70042479a237?pretty=fuller

And then a return to the old level at
https://chromium.googlesource.com/chromium/src/+log/1d744b20894a995488de7132f9726794f8b6d372%5E..7385c63ec2b3606a67bb192bf96311ada07aa1c6?pretty=fuller

My r482904 is in the list that improves the behavior, and my "Make SkImage_Lazy::onMakeColorSpace return a SkImage_Lazy" is in the list that returns the behavior to where it was before.

So, my change that improved that metric also made some other metrics much worse, and when I fixed the change to not regress the other metrics, the ones that improved went back to their old levels.