New issue
Advanced search Search tips

Issue 741694 link

Starred by 1 user
Status: Duplicate
Merged: issue gerrit:6097
Owner: ----
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----


Previous locations:
gerrit:6713


Sign in to add a comment

"Added to CC:" message for automatically added people

Project Member Reported by dullweber@chromium.org, Jul 12 2017 
I think the automatic "Added to CC:" messages in Chromium reviews are very confusing because they appear as if a person was manually added to CC.

Could they be hidden or could the messages be shown without the CL author's name to indicate that this was an automatic action?

Example:
http://crrev.com/c/566826
I added dpapad as reviewer but I neither added chromium-reviews nor dcheng, so this shouldn't appear as if I did these things.

Comment 1 by logan@google.com, Jul 12 2017

Components: -PolyGerrit
Labels: Proj-Gerrit-Migration
These extra reviewers/CCs are added by git cl upload. It might be feasible to modify the script to perform these additions under a bot account on behalf of the change owner. Sending over to chrome-infra to consider.

Comment 2 by logan@google.com, Jul 12 2017

Project: chromium
Moved issue gerrit:6713 to now be  issue chromium:741694 .

Comment 3 by logan@google.com, Jul 12 2017

Components:
I suppose the main challenge is that git cl upload would only have the change owner's credentials.

Comment 4 by aga...@chromium.org, Jul 13 2017

Mergedinto: gerrit:6097
Status: Duplicate (was: New)
Yeah, these reviewers are actually added by you. We could eventually move everything to Gerrit notify rules, rather than WATCHLISTS in the repo, but that would be a lot of work and a long way off.

The message is hidden if you click "show comments only", and there is a bug tracking a feature request to have "comments only" be the default view.
►

Sign in to add a comment