New issue
Advanced search Search tips

Issue 741690 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Password Manager Code for Old Settings Page is Likely Dead

Project Member Reported by jdoerrie@chromium.org, Jul 12 2017

Issue description

Chrome Version: 61.0.3156.0 (Developer Build) (64-bit)
OS: Linux

What steps will reproduce the problem?
(1) Try to open chrome://settings-frame/passwords

What is the expected result?
See Password Manager page.

What happens instead?
This site can’t be reached (ERR_INVALID_URL) error.
This is likely expected behavior due the deprecation of the old settings page through MD settings ( https://crbug.com/728353 ). However, that means that password manager code dealing with the old settings page is likely dead. This includes (at a minimum) the following files:

- chrome/browser/ui/webui/options/password_manager_handler.h
- chrome/browser/ui/webui/options/password_manager_handler.cc
- chrome/browser/resources/options/password_manager.css
- chrome/browser/resources/options/password_manager.html
- chrome/browser/resources/options/password_manager.js
- chrome/browser/resources/options/password_manager_list.css
- chrome/browser/resources/options/password_manager_list.js

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 

Comment 1 Deleted

Comment 2 by battre@chromium.org, Jul 13 2017

Isn't ChromeOS still on the old setting style?
True, https://crrev.com/2927273002 moved the deprecated Options UI to only ChromeOS. Testing locally chrome://settings-frame/passwords is still available there. We should keep an eye on  https://crbug.com/728353 , though.

Comment 4 by vabr@chromium.org, Oct 19 2017

Status: Fixed (was: Untriaged)
chrome://settings-frame/passwords is no longer available on CrOS 61.0.3163.120 (current stable). Seems also that the listed files are gone.

Comment 5 by vabr@chromium.org, Oct 19 2017

Labels: -Type-Bug Type-Task

Sign in to add a comment