New issue
Advanced search Search tips

Issue 741682 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Text Selection Handle is getting flickered during initial selection

Project Member Reported by ajit...@samsung.com, Jul 12 2017

Issue description

Chrome Version: 59.0.3071.125
OS: Android 7.0.0
Device: Galaxy S7 Edge SM-G935F NRD90M

What steps will reproduce the problem?
(1) Load any page say Google Privacy
(2) Long press on a word, don't release the finger
(3) Observe text selection handle is getting appeared and disappeared immediately for a small amount of time.

What is the expected result?

Text Selection handles should not appear. After releasing finger only text selection handle has some significance.

What happens instead?

Observe text selection handle is getting appeared and disappeared immediately for a small amount of time. This is happening in all fresh selections.

Reproduction video is attached.
 
selection_handle_issue.mp4
1.3 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/576b1e31d96ae200aab96ec4645aed2123b44941

commit 576b1e31d96ae200aab96ec4645aed2123b44941
Author: AJITH KUMAR V <ajith.v@samsung.com>
Date: Mon Jul 24 19:12:38 2017

Fixing text selection handles getting appeared before finger release

Alpha value for selection handle is not reset correctly during
clearing of selection. This is making touch handle showing for
a small duration. Clearing the visibility state of handles during
selection clear, so that it will automatically set the alpha value
to 0 during fade animation.

Bug:  741682 
Change-Id: I40d31e705637680bbe1cddaa9f857b7f4cca2324
Reviewed-on: https://chromium-review.googlesource.com/571210
Commit-Queue: AJITH KUMAR V <ajith.v@samsung.com>
Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489041}
[modify] https://crrev.com/576b1e31d96ae200aab96ec4645aed2123b44941/ui/touch_selection/touch_handle.cc
[modify] https://crrev.com/576b1e31d96ae200aab96ec4645aed2123b44941/ui/touch_selection/touch_handle.h
[modify] https://crrev.com/576b1e31d96ae200aab96ec4645aed2123b44941/ui/touch_selection/touch_handle_unittest.cc
[modify] https://crrev.com/576b1e31d96ae200aab96ec4645aed2123b44941/ui/touch_selection/touch_selection_controller_test_api.cc
[modify] https://crrev.com/576b1e31d96ae200aab96ec4645aed2123b44941/ui/touch_selection/touch_selection_controller_test_api.h
[modify] https://crrev.com/576b1e31d96ae200aab96ec4645aed2123b44941/ui/touch_selection/touch_selection_controller_unittest.cc

Comment 2 by ajit...@samsung.com, Jul 25 2017

Owner: ajit...@samsung.com
Status: Fixed (was: Untriaged)

Sign in to add a comment