New issue
Advanced search Search tips

Issue 741678 link

Starred by 2 users
Status: Fixed
Owner:
beccahughes@chromium.org
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 715051



Sign in to add a comment

Media Engagement: minimum video size should be 200x140

Project Member Reported by mlamouri@chromium.org, Jul 12 2017 
The media engagement code requires a 200x200 video at the moment. We should change this to be 200x140 (width x height) for consistency with Watch Time.

See  bug 711792
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/850575d376f717c38fb6bb9c48d35d648705f6d2

commit 850575d376f717c38fb6bb9c48d35d648705f6d2
Author: Becca Hughes <beccahughes@chromium.org>
Date: Thu Jul 13 13:54:19 2017

Media Engagement: minimum video size should be 200x140

As per the WatchTime code the minimum video frame size used should
be 200x140.

BUG= 741678 

Change-Id: I74c1fef945918f539ce82654d9ebdeb7c21a0bcd
Reviewed-on: https://chromium-review.googlesource.com/570044
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486362}
[modify] https://crrev.com/850575d376f717c38fb6bb9c48d35d648705f6d2/chrome/browser/media/media_engagement_contents_observer.cc
[modify] https://crrev.com/850575d376f717c38fb6bb9c48d35d648705f6d2/chrome/browser/media/media_engagement_contents_observer.h
[modify] https://crrev.com/850575d376f717c38fb6bb9c48d35d648705f6d2/chrome/browser/media/media_engagement_contents_observer_unittest.cc

Comment 2 by beccahughes@chromium.org, Jul 13 2017

Status: Fixed (was: Assigned)

Comment 3 by hbengali@chromium.org, Jul 13 2017 

We should also update the below doc to reflect the change:

https://docs.google.com/document/d/1_278v_plodvgtXSgnEJ0yjZJLg14Ogf-ekAFNymAJoU/edit?usp=sharing

Comment 4 by beccahughes@chromium.org, Jul 13 2017 

Done :)

Comment 5 by beccahughes@chromium.org, Aug 30 2017

Blocking: 715051
►

Sign in to add a comment