New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 741671 link

Starred by 2 users
Status: Fixed
Owner:
█ gsennton@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
Cc:
michaelbai@chromium.org
torne@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task



Sign in to add a comment

android_webview/glue/BUILD.gn:is_upstream is obsolete

Project Member Reported by gsennton@chromium.org, Jul 12 2017 
There is only one copy of of android_webview/glue/BUILD.gn nowadays, so the variable is_upstream will always be true.

Any logic related to is_upstream being false can be removed.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c6789c519b491e1da164baa9484fe489cd4e24e

commit 2c6789c519b491e1da164baa9484fe489cd4e24e
Author: Gustav Sennton <gsennton@google.com>
Date: Wed Jul 12 19:25:24 2017

[Android WebView] remove downstream build spec from glue BUILD.gn

android_webview/glue/BUILD.gn only lives upstream now, which means the
downstream specific config in there can be removed.

BUG= 741671 

Change-Id: Iebd52c575b78653dee14495ed188502e5ce92fa5
Reviewed-on: https://chromium-review.googlesource.com/568308
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Gustav Sennton <gsennton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486052}
[modify] https://crrev.com/2c6789c519b491e1da164baa9484fe489cd4e24e/android_webview/glue/BUILD.gn

Comment 2 by gsennton@chromium.org, Jul 13 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment