New issue
Advanced search Search tips

Issue 741652 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

dice_browsertest is flaky on windows

Project Member Reported by primiano@chromium.org, Jul 12 2017

Issue description

A CL failed CQ because of this flakiness:

CL: https://chromium-review.googlesource.com/c/554280
Link to failure:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2Fwin_chromium_x64_rel_ng%2F467527%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests__with_patch_%2F0%2Flogs%2FDiceBrowserTest.Signin%2F0

Very likely the culprit is https://chromium-review.googlesource.com/c/566817/
which changed that test 22 hours ago.

[1116:5672:0711/121040.637:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico
../../chrome/browser/signin/dice_browsertest.cc(300): error: Value of: token_requested_
  Actual: false
Expected: true
../../chrome/browser/signin/dice_browsertest.cc(301): error: Value of: refresh_token_available_
  Actual: false
Expected: true
../../chrome/browser/signin/dice_browsertest.cc(302): error: Value of: GetTokenService()->RefreshTokenIsAvailable(GetMainAccountID())
  Actual: false
Expected: true
[1116:5672:0711/121040.664:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /oauth2/v4/token
[1116:5672:0711/121040.664:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /oauth2/v4/token
[1116:4208:0711/121040.668:ERROR:event_page_request_manager.cc(147)] An error encountered while waking the event page.
[1116:4208:0711/121040.668:ERROR:event_page_request_manager.cc(89)] Draining request queue. (queue-length=3)
[1116:4208:0711/121040.668:ERROR:account_info_fetcher.cc(58)] OnGetTokenFailure: Request canceled.
[1116:4208:0711/121040.668:WARNING:account_fetcher_service.cc(305)] Failed to get UserInfo for main_gaia_id
[  FAILED  ] DiceBrowserTest.Signin, where TypeParam =  and GetParam() =  (1351 ms)
[ RUN      ] DiceBrowserTest.Signin
[3676:1152:0711/121041.830:ERROR:direct_composition_surface_win.cc(1007)] Failing to detect HDR, couldn't retrieve D3D11 device from ANGLE.
[3676:1152:0711/121041.833:INFO:media_foundation_video_encode_accelerator_win.cc(330)] Windows versions earlier than 8 are not supported.
[372:748:0711/121041.838:WARNING:chrome_browser_main_win.cc(475)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=DiceBrowserTest.Signin --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\w\iogz9rem\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir5388_1666\d5388_29102" --disable-offline-auto-reload --gaia-url=https://127.0.0.1:60724/ --google-apis-url=https://127.0.0.1:60724/ --account-consistency=dice --no-first-run --no-default-browser-check --enable-logging=stderr --log-level=0 --safebrowsing-disable-auto-update --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-features=NetworkPrediction --flag-switches-begin --flag-switches-end --restore-last-session about:blank
[3676:1152:0711/121041.890:ERROR:gl_surface.cc(198)] NOT IMPLEMENTED
[3676:1152:0711/121041.895:ERROR:gl_surface.cc(198)] NOT IMPLEMENTED
[3676:1152:0711/121042.001:ERROR:gl_surface.cc(198)] NOT IMPLEMENTED
[3676:1152:0711/121042.005:ERROR:gl_surface.cc(198)] NOT IMPLEMENTED
[372:2120:0711/121042.137:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico
../../chrome/browser/signin/dice_browsertest.cc(300): error: Value of: token_requested_
  Actual: false
Expected: true
../../chrome/browser/signin/dice_browsertest.cc(301): error: Value of: refresh_token_available_
  Actual: false
Expected: true
../../chrome/browser/signin/dice_browsertest.cc(302): error: Value of: GetTokenService()->RefreshTokenIsAvailable(GetMainAccountID())
  Actual: false
Expected: true
[372:2120:0711/121042.156:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /oauth2/v4/token
[372:2120:0711/121042.156:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /oauth2/v4/token
[372:748:0711/121042.162:ERROR:oauth2_access_token_fetcher_impl.cc(250)] Unexpected persistent error: http_status=404
[372:748:0711/121042.162:ERROR:account_info_fetcher.cc(58)] OnGetTokenFailure: Invalid credentials.
[372:748:0711/121042.163:WARNING:account_fetcher_service.cc(305)] Failed to get UserInfo for main_gaia_id
[372:748:0711/121042.163:ERROR:oauth2_access_token_fetcher_impl.cc(250)] Unexpected persistent error: http_status=404
[372:748:0711/121042.168:ERROR:event_page_request_manager.cc(147)] An error encountered while waking the event page.
[372:748:0711/121042.168:ERROR:event_page_request_manager.cc(89)] Draining request queue. (queue-length=3)
[372:748:0711/121043.077:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[  FAILED  ] DiceBrowserTest.Signin, where TypeParam =  and GetParam() =  (1356 ms)
 

Comment 1 by droger@chromium.org, Jul 12 2017

Indeed I see some failures for this particular test on the flakiness dashboard:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=DiceBrowserTest

This is the only test in the suite that is flaky, and it happens on windows only.

Note that the suggested CL is likely not the culprit, since it does not actually touch this test.

Comment 2 by droger@chromium.org, Jul 13 2017

Status: Assigned (was: Unconfirmed)
I don't have access to a windows machine to debug now. I'm going to disable the test on windows for now.

Comment 3 by droger@chromium.org, Jul 13 2017

Cc: droger@chromium.org
 Issue 742090  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d122b121436f817f5ec31604297e88f12b9f59dc

commit d122b121436f817f5ec31604297e88f12b9f59dc
Author: David Roger <droger@chromium.org>
Date: Thu Jul 13 09:57:34 2017

Disable DiceBrowserTest.Signin on windows

The test is flaky on windows.

TBR=msarda

Bug:  741652 
Change-Id: I87507685fad4764d61856519f1bd39043cc52c13
Reviewed-on: https://chromium-review.googlesource.com/569740
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486329}
[modify] https://crrev.com/d122b121436f817f5ec31604297e88f12b9f59dc/chrome/browser/signin/dice_browsertest.cc

Comment 5 by ew...@chromium.org, Jul 20 2017

Is this fixed? Or should it still be P1?

Comment 6 by droger@chromium.org, Jul 21 2017

Labels: -Pri-1 Pri-2
Owner: msarda@chromium.org
Lowering to P2. This is no longer blocking anyone, but would still be nice to identify the issue.
There is a probability that the bug is in the test rather than in the code, but we would need to investigate to be sure.

Tentatively assigning to msarda who has a Windows machine.
msarda: could you try running that test on Windows to see if you can repro the flake? Or could you give me access to your machine so that I can debug it?
Project Member

Comment 7 by sheriffbot@chromium.org, Aug 21 2017

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by droger@chromium.org, Sep 14 2017

Cc: -droger@chromium.org
Owner: droger@chromium.org
Status: Started (was: Available)
I'm taking another look at this.

It seems that I can somewhat repro the flakiness using the trybots.
I'm adding more logging to diagnose the issue.

So far it seems that the problem is a request from Gaia auth fetcher that is never reaching the test server. The request looks correct, so the problem maybe related to the test server setup.
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/755dc93b09b62d0d62f5101e8e28b4a1fc606254

commit 755dc93b09b62d0d62f5101e8e28b4a1fc606254
Author: David Roger <droger@chromium.org>
Date: Fri Sep 15 15:03:51 2017

Re-enable DiceBrowserTest.Signin on Windows

This CL fixes the race condition in DiceBrowserTest.
The bug was happening because the test was not waiting correctly
for server responses: it was using RunLoop::RunUntilIdle() which
is not correct because the server runs on a background thread.

Bug:  741652 
Change-Id: Icd94b41ff53652f01b5ddddb578bb20dde8df83d
Reviewed-on: https://chromium-review.googlesource.com/666682
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502255}
[modify] https://crrev.com/755dc93b09b62d0d62f5101e8e28b4a1fc606254/chrome/browser/signin/dice_browsertest.cc
[modify] https://crrev.com/755dc93b09b62d0d62f5101e8e28b4a1fc606254/chrome/browser/signin/dice_response_handler.cc

Status: Fixed (was: Started)
This should be fixed. I'll keep an eye to see if it flakes again, and reopen if needed.

Sign in to add a comment