https://chromium-review.googlesource.com/568100/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38fdbcd12c8beb2afd4fdd0d6504c94b053c9c2b

commit 38fdbcd12c8beb2afd4fdd0d6504c94b053c9c2b
Author: Mark Mentovai <mark@chromium.org>
Date: Wed Jul 12 13:46:29 2017

mac: Disable unit_tests WebAppShortcutCreatorTest.RevealAppShimInFinder

This test is flaky (sometimes crashes) on "Mac10.10 Tests".

TBR=tapted@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Bug: 741642
Change-Id: I53925b699979d967d3e3aa1df73436dfefdcbd57
Reviewed-on: https://chromium-review.googlesource.com/568100
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485938}
[modify] https://crrev.com/38fdbcd12c8beb2afd4fdd0d6504c94b053c9c2b/chrome/browser/web_applications/web_app_mac_unittest.mm

ngh. no stacktrace symbols :/. Nothing stands out yet, but I'll take a look.

r484473 switched the shortcut code over to TaskScheduler... But these unit tests don't spawn a worker pool. And I think the actual meat of the function is mocked anyway.

It's possible RevealAppShimInFinder is upset for some other reason. Maybe a task is sneaking through that's upsetting AppKit in 10.10.


[ RUN      ] WebAppShortcutCreatorTest.RevealAppShimInFinder
Received signal 4 <unknown> 00010c372cfe
 [0x00010b96939c]
 [0x00010b969291]
 [0x7fff90122f1a]
 [0x0001245e5680]
 [0x00010c372b61]
 [0x7fff8a3fbaac]
 [0x7fff8a3fb998]
 [0x7fff8dd0c55b]
 [0x7fff8dd0c417]
 [0x7fff8dd0c217]
 [0x7fff8dd0c009]
 [0x00010d5badd0]
 [0x00010d5bb4e7]
 [0x00010d5bb3d3]
 [0x00010b969b92]
 [0x00010b9d5c31]
 [0x00010b9d61b3]
 [0x00010b9d5834]
 [0x00010b9d1308]
 [0x00010b9e0e67]
 [0x7fff904ad05a]
 [0x7fff904acfd7]
 [0x7fff904aa3ed]
[end of stack trace]

Flakiness dashboard also has confusing output: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&tests=WebAppShortcutCreatorTest.RevealAppShimInFinder

No crashes on Mac10.11 Tests

Comparing

https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/20707 (r485877) ran fine
 > [4878/7799] WebAppShortcutCreatorTest.RevealAppShimInFinder (317 ms)


https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/20708 (r485882) first crashed recorded, succeeded on second retry
 > [5168/7799] WebAppShortcutCreatorTest.RevealAppShimInFinder (CRASHED)
 > Retrying 1 test (retry #2)
 > [7817/7817] WebAppShortcutCreatorTest.RevealAppShimInFinder (208 ms)


There are kinda far from r484473, but it could still be plausible that r484473 contributed to it.