New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 741594 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.7% regression in system_health.memory_mobile at 485346:485467

Project Member Reported by petermarshall@chromium.org, Jul 12 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jul 12 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=741594

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=e941e193649ad179a0cd7c3088d0aef469e42fceee7fada995e2a96d66f7b2be


Bot(s) for this bug's original alert(s):

android-nexus7v2
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jul 12 2017

Cc: vabr@chromium.org
Owner: vabr@chromium.org

=== Auto-CCing suspected CL author vabr@chromium.org ===

Hi vabr@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Vaclav Brozek
  Commit : 7020c4e0d2a6b5943ef920e5a14054ab4b198da9
  Date   : Mon Jul 10 21:50:36 2017
  Subject: Support federated credentials in password settings on iOS

Bisect Details
  Configuration: android_nexus7_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:renderer_processes:reported_by_chrome:v8:heap:effective_size_avg/load_games/load_games_bubbles
  Change       : 3.03% | 7266277.52381 -> 7486306.85714

Revision             Result                  N
chromium@485345      7266278 +- 235369       21      good
chromium@485409      7252205 +- 96209.8      14      good
chromium@485410      7355097 +- 663513       14      bad       <--
chromium@485413      7306399 +- 234385       14      bad
chromium@485417      7371769 +- 638435       9       bad
chromium@485423      7359087 +- 699177       14      bad
chromium@485439      7329501 +- 670373       14      bad
chromium@485467      7486307 +- 1077432      14      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.games.bubbles system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8974276715811091440


For feedback, file a bug with component Speed>Bisection

Comment 4 by vabr@chromium.org, Jul 13 2017

Cc: -vabr@chromium.org
Owner: ----
IIUC, the regression is on Android bots. My blamed change r485410 was exclusively for iOS (only changing files inside //ios), so clearly not the culprit.
Status: WontFix (was: Untriaged)
Yes it seems impossible that those iOS changes could affect Android here, and we only see this on one platform anyway. I'll close as the effect is small anyway, and the bot seems to be fairly noisy.

Sign in to add a comment