New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 741581 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Window title bar is seen overlapped with tab in overview mode.

Project Member Reported by jbanavatu@chromium.org, Jul 12 2017

Issue description

Chrome Version: 61.0.3154.0/9736.0.0 dev channel Daisy,Kip,Paine
OS:Chrome OS

What steps will reproduce the problem?
(1)Sign in to user >> Open any 2 or 3 windows  
(2)Now hit Overview mode button and Observe Window title bar

Expected: No such overlapping of window title bar and tab should be seen in overview mode.
Actual:Instead, Window title bar is seen overlapped with tab in overview mode. 

This is regression issue as no such overlapping of window title bar and tab is seen in 61.0.3144.0/9693.1.0 dev channel Daisy.

Note: Issue is not seen in Windows & Linux OS

Attaching screenshots for reference.
 
Actual.jpg
2.9 MB View Download
Expected.jpg
3.3 MB View Download

Comment 1 by varkha@chromium.org, Jul 13 2017

Cc: wutao@chromium.org x...@chromium.org varkha@chromium.org
Status: Available (was: Untriaged)
I can see it in chromeos=1 ToT build on linux and will bisect shortly. r484310 is still good a few days a go.

Comment 2 by wutao@chromium.org, Jul 13 2017

On linux, non-official build, rebased yesterday (77cf3bbc98957d0f19da8b01afc47028c401cf79), the title looks fine.

Comment 3 by varkha@chromium.org, Jul 13 2017

Cc: csmartdalton@chromium.org
Owner: reed@chromium.org
Status: Assigned (was: Available)
# first bad commit: [f53b0375775430158df440550f3d6712a0fd205e] Roll src/third_party/skia/ 7aad8cc2f..b1de5f9f2 (12 commits)

URL for sia roll review (12 commits):
https://skia.googlesource.com/skia.git/+log/7aad8cc2ff7a..b1de5f9f2737

Suspecting https://skia-review.googlesource.com/c/21368/ but it could be any other of the patches that went into this roll.

reed@, can you please take a look and see if it was indeed you patch that cause this.

Repro steps that work for me:
- build Chrome for Chrome OS (target_os = "chromeos")
- Launch Chrome
- Open a tab-less browser window (e.g. File manager app - Alt+Shift+M)
- Make File manager window as small as you can (minimum allowed size)
- Press F5 to get into overview mode.

Compare to the attached screenshots - the original header should be hidden rather than protruding above the overview mode header.
For reference - this is where we install alpha shape on the window:
https://cs.chromium.org/chromium/src/ash/wm/overview/scoped_transform_overview_window.cc?l=385

+csmartdalton@ as a reviewer of the roll.
alpha-shape-bad.png
82.4 KB View Download
alpha-shape-good.png
80.3 KB View Download

Comment 4 by ketakid@google.com, Aug 31 2017

Issue has not been touched July 13th. reed@ can you please comment on if this is still a RBS and if you have a fix for this?
Labels: -ReleaseBlock-Stable
I'm unable to repro in 61.0.3163.51 
Owner: reed@google.com

Sign in to add a comment