Issue metadata
Sign in to add a comment
|
Regression : Unnecessarily 'Custom name servers' option is selected at 'Name servers' on disabling 'Configure IP address automatically' in chrome://md-settings |
||||||||||||||||||||||
Issue descriptionChrome Version: 61.0.3154.0/9736.0.0 dev channel Paine,Kip and Daisy OS: Chrome What steps will reproduce the problem? (1)Sign into User -> Go to chrome://md-settings page -> At 'Network' section click on Wi-Fi -> select Connected Wi-Fi network (2)Click on 'Network' -> observe 'Automatic name servers' is seen by default at 'Name servers' (3)Now disable 'Configure IP address automatically' option and observe 'Custom name servers' is selected at 'Name servers' (Please refer video and screenshot) Expected: On enabling or disabling 'Configure IP address automatically' option no effect should be seen at 'Name servers' i.e. 'Name servers' options can be selected manually Actual: Instead 'Custom name servers' is selected at 'Name servers' on disabling 'Configure IP address automatically' option This is Regression issue as same is working fine in 61.0.3136.5/9672.0.0 dev-channel Kip @stevenjb : Please confirm the issue Note: 1.Issue is working fine in chrome://settings page(Please refer 'Expected_InOldSettings' video) 2.Even after Enabling 'Configure IP address automatically' option also 'Custom name servers' is seen at 'Name servers'
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d416df5adffba0031c2fe4e0897b3a094927f8cd commit d416df5adffba0031c2fe4e0897b3a094927f8cd Author: Steven Bennetts <stevenjb@chromium.org> Date: Fri Jul 21 20:48:43 2017 Settings: Network: Send only correct Static IP properties Bug: 741574 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icc1a265948cb90c72ee9b9e2fd4447220b5f9f0f Reviewed-on: https://chromium-review.googlesource.com/580369 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#488744} [modify] https://crrev.com/d416df5adffba0031c2fe4e0897b3a094927f8cd/chrome/browser/resources/settings/internet_page/internet_detail_page.js
,
Jul 21 2017
,
Jul 21 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-61; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-61 label, otherwise remove Merge-TBD label. Thanks.
,
Jul 21 2017
,
Jul 22 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39d27c46164621f7ee380a39df7656366404b09c commit 39d27c46164621f7ee380a39df7656366404b09c Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Jul 24 16:13:03 2017 Settings: Network: Send only correct Static IP properties TBR=stevenjb@chromium.org (cherry picked from commit d416df5adffba0031c2fe4e0897b3a094927f8cd) Bug: 741574 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icc1a265948cb90c72ee9b9e2fd4447220b5f9f0f Reviewed-on: https://chromium-review.googlesource.com/580369 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#488744} Reviewed-on: https://chromium-review.googlesource.com/583294 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#10} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/39d27c46164621f7ee380a39df7656366404b09c/chrome/browser/resources/settings/internet_page/internet_detail_page.js
,
Jul 26 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, Jul 12 2017