New issue
Advanced search Search tips

Issue 741546 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

factory: Improve wiping code.

Project Member Reported by hungte@chromium.org, Jul 12 2017

Issue description

Currently the wiping (and reset) is done by wipe-in-place, calling clobber-state.

However, clobber-state may have many extra unexpected dependency and changes randomly.

Currently, clobber-state does these:
 - ensure root account (we don't need)
 - redirect logs (we don't need)
 - preserve files (we need but this can be done in other ways)
 - detect system config (mainly for NAND and rotational devices, but since no projects are going NAND/rotational maybe we can skip this)
 - wipe stateful by dd (we can do this)
 - create new file system (we have to clone this)
 - mount and restore CRX cache (need to do this)
 - tag developer mode flags (probably need)
 - remove VPD keys (we can do this in factory)

Maybe we should just do the clobbering (since what we need is slightly different from what clobber-state usually needs) inside factory script, that may include:

 - Stop using display_boot_message and other functions that needs fonts & graphics
 - Invoke frecon only one time and use its OSC (Escape code) to display images if needed, or do pure text UI
 - Also change cutoff scripts to take advantage of the frecon / text UI.
 

Comment 1 by hungte@chromium.org, Jul 12 2017

One reason for this is the clobber-state is becoming more and more designed for power-wash so many checks and dependency there may be related to things we don't care.

Also, clobber-state comes from test image and would be a dependency problem when some projects try to use test image from release image branches.

Comment 2 by hungte@chromium.org, Jul 13 2017

Cc: -youcheng@chromium.org -petershih@chromium.org -yhong@chromium.org -pihsun@chromium.org -yllin@chromium.org -stimim@chromium.org chromeos-factory-eng@google.com
Labels: Hotlist-GoodFirstBug
Owner: fshao@chromium.org
Status: Assigned (was: Untriaged)

Sign in to add a comment