New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 741528 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Nothing happens on clicking “Open PDF in preview” option on print preview page.

Reported by aiman.an...@etouch.net, Jul 12 2017

Issue description

Chrome Version: 61.0.3155.0 (Official Build) 981b49ad53b91e640ca9e83751e73f9c60dcf782-refs/heads/master@{#485784} (32/64-bit).

OS: Mac(10.12.3, 10.11.6).

Steps to reproduce: 
1.Launch Chrome, go to NTP, give print command and click on “Open PDF in preview”.
2.Observe.

Actual Result: Nothing happens on clicking “Open PDF in preview” option.
Expected Result: PDF file should open in preview.

This is Regression Issue broken in M-61 and will soon update the bisect info.

Manual Bisect Info:
Good Build: 61.0.3143.0
Bad Build: 61.0.3144.0

Note: Issue is Mac Specific.
 
Actual Result.mov
3.7 MB Download
Expected Result.mov
6.2 MB Download
Cc: jmukthavaram@chromium.org
Labels: hasbisect-per-revision
Owner: rbpotter@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Mac 10.12.5 using chrome latest Canary-61.0.3154.0.
Manual Bisect Info:
-------------------
Good Build: 61.0.3143.0-Revision-482834
Bad Build: 61.0.3144.0-Revision-483234

Per revision bisect info:
-------------------------
You are probably looking for a change made after 482854 (known good), but no later than 482855 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/2f502a91eb07a2c8f68f9c83d250a5d39c76327f..63f156d9c2dfd6a04d1a49a58a1c0178b1e3f6e1

Possible suspect:
----------------
https://chromium.googlesource.com/chromium/src/+/63f156d9c2dfd6a04d1a49a58a1c0178b1e3f6e1

rbpotter@Could you please take a look and reassign to the right owner if it is not related tp your change.
Thanks..!!
Labels: ReleaseBlock-Stable
Adding Release Block-Stable for this issue.Please remove if not the case.

Thank You!
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68545ad5787891a4a197a165b050539ec8dedd54

commit 68545ad5787891a4a197a165b050539ec8dedd54
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Jul 12 21:58:25 2017

Print preview: Fix bug with Mac "open in preview"

Mac's "Open in Preview" is treated as a local printer in the C++
handler. Always treat it as a local printer in print_preview.js as well
so that the "print" promise resolution correctly closes the dialog and
prompts Preview to open.

BUG= 741341 , 741528 

Change-Id: I831df003019274edecf73172ef1e06bd6ebc960e
Reviewed-on: https://chromium-review.googlesource.com/568239
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486119}
[modify] https://crrev.com/68545ad5787891a4a197a165b050539ec8dedd54/chrome/browser/resources/print_preview/print_preview.js

Comment 4 by ajha@chromium.org, Jul 13 2017

Labels: TE-Verified-M61 TE-Verified-61.0.3156.0
Tested this on Mac canary version: 61.0.3156.0 and this seems to be working as intended and PDF file is opened in preview.
Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a6a1f024c7bed6b199e181a662e12c3229740c0

commit 1a6a1f024c7bed6b199e181a662e12c3229740c0
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Jul 14 14:28:32 2017

Print Preview: Add tests for "Open PDF in Preview" and System Dialog

Add tests to verify print preview behaves as expected when the "Open
PDF in Preview" link is clicked on MacOS, and when "Print with System
Dialog" is clicked on Windows.

Bug:  741341 ,  741528 
Change-Id: I1174ec935eeea1b90e7853eb1e13d1fe3c596809
Reviewed-on: https://chromium-review.googlesource.com/570831
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486754}
[modify] https://crrev.com/1a6a1f024c7bed6b199e181a662e12c3229740c0/chrome/test/data/webui/print_preview/native_layer_stub.js
[modify] https://crrev.com/1a6a1f024c7bed6b199e181a662e12c3229740c0/chrome/test/data/webui/print_preview/print_preview_tests.js
[modify] https://crrev.com/1a6a1f024c7bed6b199e181a662e12c3229740c0/chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js

Sign in to add a comment