MostVisitedSites::Refresh doesn't work with TopSites |
||||
Issue descriptionMostVisitedSites::Refresh is supposed to trigger a refresh of the tiles in the background. In practice, it just calls suggestions_service_->FetchSuggestionsData() (i.e. tries to update MostLikely). That makes sense; however if SuggestionsService returns no results, e.g. because the user isn't signed in, the refresh request just gets dropped, instead of being redirected to TopSites. That means currently it's not possible to trigger a refresh of TopSites through MostVisitedSites.
,
Jul 20 2017
Over to mastiz then, who can delegate if necessary :)
,
Jul 20 2017
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d90c8175b1f4057e0e38afca54eeb65f0e2b25c commit 1d90c8175b1f4057e0e38afca54eeb65f0e2b25c Author: Mikel Astiz <mastiz@chromium.org> Date: Fri Jul 21 13:52:51 2017 Fix InstantService not refreshing TopSites when kNtpTilesFeature enabled InstantService is the only caller of MostVisitedSites::Refresh() and it is obvious from the caller's side that TopSites should be refreshed too, when an NTP is opened. Prior to this patch, TopSites would be updated time-based, leading to more stale NTP tiles when the feature kNtpTilesFeature is enabled (non-default case). The bug is believed to make little impact. Bug: 741431 Change-Id: Iccdc4f89d3ab430eafd9a2faf1b1564f363ff29f Reviewed-on: https://chromium-review.googlesource.com/581147 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#488647} [modify] https://crrev.com/1d90c8175b1f4057e0e38afca54eeb65f0e2b25c/chrome/browser/ntp_tiles/ntp_tiles_browsertest.cc [modify] https://crrev.com/1d90c8175b1f4057e0e38afca54eeb65f0e2b25c/components/ntp_tiles/most_visited_sites.cc [modify] https://crrev.com/1d90c8175b1f4057e0e38afca54eeb65f0e2b25c/components/ntp_tiles/most_visited_sites_unittest.cc
,
Jul 24 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by fi...@chromium.org
, Jul 20 2017