Issue metadata
Sign in to add a comment
|
Regression: Unresponsive “ Print using system dialogue” button is seen on Print Preview page.
Reported by
aiman.an...@etouch.net,
Jul 12 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: 61.0.3155.0 (Official Build) 981b49ad53b91e640ca9e83751e73f9c60dcf782-refs/heads/master@{#485784} (32/64-bit) OS: Mac(10.12.3, 10.11.6). Steps to reproduce: 1.Launch Chrome, go to NTP, give print command and click on “Open PDF in preview”. 2.Observe. Actual Result: Unnecessary “ Print using system dialogue” button is seen and also the button is unresponsive. Expected Result: Button should not be seen or should be responsive. This is Regression Issue broken in M-61 and will soon update the bisect info. Manual Bisect Info: Good Build: 61.0.3139.0 Bad Build: 61.0.3140.0 Note: Issue is not reproducible on Win and Linux.
,
Jul 12 2017
Adding Release Block-Stable for this issue.Please remove if not the case. Thank You!
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68545ad5787891a4a197a165b050539ec8dedd54 commit 68545ad5787891a4a197a165b050539ec8dedd54 Author: rbpotter <rbpotter@chromium.org> Date: Wed Jul 12 21:58:25 2017 Print preview: Fix bug with Mac "open in preview" Mac's "Open in Preview" is treated as a local printer in the C++ handler. Always treat it as a local printer in print_preview.js as well so that the "print" promise resolution correctly closes the dialog and prompts Preview to open. BUG= 741341 , 741528 Change-Id: I831df003019274edecf73172ef1e06bd6ebc960e Reviewed-on: https://chromium-review.googlesource.com/568239 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#486119} [modify] https://crrev.com/68545ad5787891a4a197a165b050539ec8dedd54/chrome/browser/resources/print_preview/print_preview.js
,
Jul 13 2017
With the fix from Issue 741528 , there is no 'Print using system dialogue' button on preview. This is working as intended and PDF file is opened in preview.
,
Jul 13 2017
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a6a1f024c7bed6b199e181a662e12c3229740c0 commit 1a6a1f024c7bed6b199e181a662e12c3229740c0 Author: rbpotter <rbpotter@chromium.org> Date: Fri Jul 14 14:28:32 2017 Print Preview: Add tests for "Open PDF in Preview" and System Dialog Add tests to verify print preview behaves as expected when the "Open PDF in Preview" link is clicked on MacOS, and when "Print with System Dialog" is clicked on Windows. Bug: 741341 , 741528 Change-Id: I1174ec935eeea1b90e7853eb1e13d1fe3c596809 Reviewed-on: https://chromium-review.googlesource.com/570831 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#486754} [modify] https://crrev.com/1a6a1f024c7bed6b199e181a662e12c3229740c0/chrome/test/data/webui/print_preview/native_layer_stub.js [modify] https://crrev.com/1a6a1f024c7bed6b199e181a662e12c3229740c0/chrome/test/data/webui/print_preview/print_preview_tests.js [modify] https://crrev.com/1a6a1f024c7bed6b199e181a662e12c3229740c0/chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by aiman.an...@etouch.net
, Jul 12 2017Owner: rbpotter@chromium.org
Status: Assigned (was: Unconfirmed)