New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 741329 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 741324



Sign in to add a comment

Create EarlGrey integration tests for NTP tiles

Project Member Reported by baxley@chromium.org, Jul 12 2017

Issue description

EarlGrey tests should be created for top sites. Some cases to cover...
- Navigate to a URL and verify there is an NTP tile from TopSites.
- Navigate to a URL with a server redirect and verify the initial URL is displayed.
- Make a call to MostVisitedSites.Refresh() and verify it updates the tiles.
 

Comment 1 by baxley@chromium.org, Jul 12 2017

Blocking: 741324
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93137cbd29ad4b2517a6fe93787679f48d515357

commit 93137cbd29ad4b2517a6fe93787679f48d515357
Author: Mike Baxley <baxley@chromium.org>
Date: Wed Jul 12 15:17:34 2017

Add EarlGrey test to verify NTP tiles on a redirect URL.

Test verifies that only one tile is present.

Bug:  741329 
Change-Id: I30bb1d7f1f0a5af13ccb2d364d97fe3d67ae6d88
Reviewed-on: https://chromium-review.googlesource.com/568025
Commit-Queue: Mike Baxley <baxley@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485954}
[modify] https://crrev.com/93137cbd29ad4b2517a6fe93787679f48d515357/ios/chrome/browser/ntp_tiles/ntp_tiles_egtest.mm

Comment 3 by baxley@chromium.org, Nov 21 2017

Status: Fixed (was: Started)
EarlGrey tests have been running for several months on this. Closing.

Sign in to add a comment