New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 741315 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Email to this user bounced
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Feature



Sign in to add a comment

[sensor] LinearAccelerationSensor is inactive on Windows

Reported by canx....@intel.com, Jul 12 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3141.7 Safari/537.36

Steps to reproduce the problem:
Steps to reproduce the problem:
1. Debug in the Console as below:
let las = new LinearAccelerationSensor();
las.onreading= () => {console.log("x :"+las.x,"y :"+las.y,"z :"+las.z)}
las. start();
2. Rotate the device

What is the expected behavior?
The x/y/z attribute of LinearAccelerationSensor should display.

What went wrong?
Sensor is inactive, no reading. 
Please refer to the attachment file "debug.JPG"

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 61.0.3153.1  Channel: canary
OS Version: 10.0
Flash Version:
 
debug.JPG
4.8 MB View Download
Cc: ligim...@chromium.org
Labels: Needs-Bisect Needs-Triage-M61
Whats the device configuration that you are using?

Comment 2 Deleted

Comment 3 by canx....@intel.com, Jul 14 2017

My hardware is Dell Inspiron 13 7000 Series which supports the Accelerometer sensor.
Cc: brajkumar@chromium.org
Components: Blink>Sensor>DeviceOrientation
Labels: Needs-Feedback
Tested this issue on Windows-10 Dell Precision M3800 using chrome latest canary #61.0.3156.0. By entering the script in the dev console provided in the step-1 from original comment observed syntax error saying "Identifier 'las' has already been declared".

Reporter@ Could you please let us know is this is the right way to reproduce this issue? If we missing any steps please correct us, It will be helpful to check it from Chrome TE end.

Thanks!

Comment 5 by canx....@intel.com, Jul 14 2017

At first, you should enable the 'Generic Sensor' in chrome://flags, 
According to your comments "Identifier 'las' has already been declared", you can use the other 'Identifier'(for example: let a = new LinearAccelerationSensor(); or let b = new LinearAccelerationSensor();) 

BTW, this bug owner is alexander.shalamov@intel.com, could someone help to assign  this bug to alexander? thanks.
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 14 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "brajkumar@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Needs-Bisect M-61
Owner: alexande...@intel.com
Status: Assigned (was: Unconfirmed)
Tested this issue on Windows-10 using chrome latest canary #61.0.3159.0 by following steps mentioned in the comment #5. By entering the provided script in console observed no changes and just displays undefined.
 
As per comment #5 assigning to @alexander for more updates on this issue.
Components: -Blink>Sensor>DeviceOrientation Blink>Sensor
Labels: -Type-Bug OS-Chrome OS-Linux OS-Mac Type-Feature
Summary: [sensor] LinearAccelerationSensor is inactive on Windows (was: [sensor]LinearAccelerationSensor is inactive on Windows)
Sorry for delay, I was OOO. Windows does not provide APIs for LinearAccelerationSensor, thus, sensor fusion should be implemented. I'm not sure whether this is a bug, more like an unimplemented feature (at the moment, only Android provides linear acceleration sensor data).

Would be nice to land generic fusion classes first https://chromium-review.googlesource.com/c/578253/ then it would be easier to add support for linear acceleration sensor on windows, mac, cros and linux platforms.
Status: Started (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41ee49fe74f4a8a3b9a23269a00c141237d4647e

commit 41ee49fe74f4a8a3b9a23269a00c141237d4647e
Author: Alexander Shalamov <alexander.shalamov@intel.com>
Date: Tue Aug 01 11:28:20 2017

[sensors][win] Implement linear acceleration fusion sensor

Windows Sensor COM API does not provide linear acceleration sensor type,
therefore, it needs to be implemented using SW fusion algorithm. This PR
adds simple linear acceleration fusion algorithm that is based on low-pass
filter. Same algorithm can be used on CrOS, Mac and Linux platforms.

Bug:  741315 
Change-Id: I2c4fa7fc1b7e5d3bc45ecc18cb44e4d8e2b055e9
Reviewed-on: https://chromium-review.googlesource.com/591467
Commit-Queue: Alexander Shalamov <alexander.shalamov@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490943}
[modify] https://crrev.com/41ee49fe74f4a8a3b9a23269a00c141237d4647e/services/device/generic_sensor/BUILD.gn
[modify] https://crrev.com/41ee49fe74f4a8a3b9a23269a00c141237d4647e/services/device/generic_sensor/README.md
[add] https://crrev.com/41ee49fe74f4a8a3b9a23269a00c141237d4647e/services/device/generic_sensor/linear_acceleration_fusion_algorithm_using_accelerometer.cc
[add] https://crrev.com/41ee49fe74f4a8a3b9a23269a00c141237d4647e/services/device/generic_sensor/linear_acceleration_fusion_algorithm_using_accelerometer.h
[modify] https://crrev.com/41ee49fe74f4a8a3b9a23269a00c141237d4647e/services/device/generic_sensor/platform_sensor_fusion.cc
[modify] https://crrev.com/41ee49fe74f4a8a3b9a23269a00c141237d4647e/services/device/generic_sensor/platform_sensor_fusion_algorithm.cc
[modify] https://crrev.com/41ee49fe74f4a8a3b9a23269a00c141237d4647e/services/device/generic_sensor/platform_sensor_fusion_algorithm.h
[modify] https://crrev.com/41ee49fe74f4a8a3b9a23269a00c141237d4647e/services/device/generic_sensor/platform_sensor_provider_win.cc

Labels: -OS-Linux -OS-Chrome -OS-Mac
Status: Fixed (was: Started)
Fixed for Windows platform.
canx.cao@ I also added LinearAccelerationSensor to the test app https://genericsensors.appspot.com/ would be easier to verify if the issue is fixed.
I will verify it once the fix landed in new Chrome.Thanks.
alexander.shalamov@  I verified this issue with chrome canary 62.0.3174.2 on windows. it has been fixed on windows platform. Thanks.

Status: Verified (was: Fixed)
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/359350cdabc1ea4d8ce5c22877da3d97453d26b5

commit 359350cdabc1ea4d8ce5c22877da3d97453d26b5
Author: Jun Cai <juncai@chromium.org>
Date: Wed Aug 02 20:52:16 2017

Update generic sensor documentation for LINEAR_ACCELEROMETER on Windows

This is a follow-up CL for:
https://chromium-review.googlesource.com/c/591467

This CL updates documentation for LINEAR_ACCELEROMETER on Windows.

Bug:  741315 
Change-Id: Id79a4fd5292dc084a2c373daa1b86650b00714cf
Reviewed-on: https://chromium-review.googlesource.com/598637
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491489}
[modify] https://crrev.com/359350cdabc1ea4d8ce5c22877da3d97453d26b5/services/device/generic_sensor/README.md

Sign in to add a comment