New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 741308 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : 'Sort by title' option is seen disable even when bookmarked items are present.

Reported by rp...@etouch.net, Jul 12 2017

Issue description

Version: 61.0.3155.0 981b49ad53b91e640ca9e83751e73f9c60dcf782-refs/heads/master@{#485784}
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.3)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://bookmarks/ and add some new bookmarks.
2. Now click on 'Organize' iron icon and click on 'Sort by title' and observe
 
Actual: Unable to 'Sort by title' bookmarks 
Expected: Should be able to 'Sort by title' bookmarks when bookmarks are present.

This is regression issue, broken in ‘M 61’ and will soon update other info :
Good build:61.0.3154.0
Bad build: 61.0.3155.0
 
Actual_video.mp4
641 KB View Download
Expected_video.mp4
601 KB View Download
Cc: calamity@chromium.org
You are probably looking for a change made after 485562 (known good), but no later than 485563 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
 https://chromium.googlesource.com/chromium/src/+log/a8283ee78bf919fb2c785d4741c7677bec6a855b..a9256bd64c54c4194f63cc084612536e3e53ae0a

looks like this is intended as per the CL https://chromium.googlesource.com/chromium/src/+/a9256bd64c54c4194f63cc084612536e3e53ae0a

Comment 2 by rp...@etouch.net, Jul 12 2017

Summary: Regression : 'Sort by title' option is seen disable even when bookmarked items are present. (was: Regression : Unable to 'Sort by title' bookmarks.)
Update :
Observations :
1). As per the new behavior (https://chromium.googlesource.com/chromium/src/+/a9256bd64c54c4194f63cc084612536e3e53ae0a)'Sort by title' option is disabled when no bookmarks are present.
2). After adding two or more valid bookmarks,'Sort by title' option is still seen disabled(Option gets enabled after reloading the chrome://bookmarks page)
3). The expected behavior should be that, 'Sort by title' option gets enabled as soon as user adds two or more valid bookmarks without the need of reloading the page.

Comment 3 by rp...@etouch.net, Jul 12 2017

Kindly refer the attached screen cast for latest observations.
Actual_video.mp4
1.2 MB View Download
Expected_video.mp4
907 KB View Download
Cc: -calamity@chromium.org
Labels: hasbisect-per-revision
Owner: calamity@chromium.org
Status: Assigned (was: Unconfirmed)
Tested As per Comment #2&3
Using the per-revision bisect providing the bisect results,
Good build:61.0.3154.0(Revision:485485).
Bad build:61.0.3155.0(Revision:485784).

You are probably looking for a change made after 485562 (known good), but no later than 485563 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/a8283ee78bf919fb2c785d4741c7677bec6a855b..a9256bd64c54c4194f63cc084612536e3e53ae0a

From the CL above, assigning the issue to the concern owner

@calamity : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url:https://codereview.chromium.org/2973783002
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #61.0.3155.0
Cc: calamity@chromium.org
 Issue 741298  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/425697373835828bfd1c7ef0f55b53568932c0b9

commit 425697373835828bfd1c7ef0f55b53568932c0b9
Author: Christopher Lam <calamity@chromium.org>
Date: Thu Jul 20 02:31:41 2017

[MD Bookmarks] Fix sort being disabled when bookmarks are added to empty folder.

This CL fixes an issue where the sort button was not being updated when
the selected folder's children were updated.

Bug:  741308 
Change-Id: I9876950def769551664a0d26f273b6ef6bdc0cc0
Reviewed-on: https://chromium-review.googlesource.com/569531
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488104}
[modify] https://crrev.com/425697373835828bfd1c7ef0f55b53568932c0b9/chrome/browser/resources/md_bookmarks/toolbar.js
[modify] https://crrev.com/425697373835828bfd1c7ef0f55b53568932c0b9/chrome/test/data/webui/md_bookmarks/toolbar_test.js

Status: Fixed (was: Assigned)

Sign in to add a comment