Issue metadata
Sign in to add a comment
|
All ARC app windows are black. |
||||||||||||||||||||
Issue descriptionAll ARC app windows are black. On Chrome OS + ToT Chrome. Bisection pointed out: (sdk veyron_minnie R61-9608.0.0) kinaba@kinaba /ssd/chrome/src $ git bisect bad c3dec2b9fe8e3e3008b75ee9d8b67229fafc0b34 is the first bad commit commit c3dec2b9fe8e3e3008b75ee9d8b67229fafc0b34 Author: David Reveman <reveman@chromium.org> Date: Wed Jul 12 01:19:11 2017 +0000 gpu: Fix FD leak when importing DMA-bufs with multiple FDs. CreateFromHandle is expected to take ownership of all FDs so when passed multiple FDs we need to make sure they are closed if not used. BUG=b/63409814 TEST=exo_unittests --gtest_also_run_disabled_tests --gtest_filter=DisplayTest.DISABLED_CreateLinuxDMABufBuffer Change-Id: I2a8a7b0149a08f08890a725c6ce9aff8aeaab97f Reviewed-on: https://chromium-review.googlesource.com/566879 Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485761}
,
Jul 12 2017
David reverted the original patch. https://chromium-review.googlesource.com/c/566863/
,
Jul 13 2017
Reland. Hope it goes well https://chromium-review.googlesource.com/c/566960/
,
Jul 13 2017
reprod on Chrome OS 9740.0.0, 61.0.3155.0
,
Jul 13 2017
Neither the revert (https://chromium-review.googlesource.com/c/566863/) nor the reland (https://chromium-review.googlesource.com/c/566960/) are in Chrome 61.0.3155.0. The revert should be in Chrome 61.0.3156.0 [1] but the reland didn't quite make it in for that Chrome version - I'd expect it to be in 61.0.3157.0 (not yet tagged...). Also, Chrome PFQ hasn't rolled ChromeOS to 61.0.3156.0 just yet. [1] https://chromium.googlesource.com/chromium/src/+log/61.0.3155.0..61.0.3156.0?pretty=fuller&n=10000
,
Jul 14 2017
The bug seems to be resolved in 61.0.3156.0, but it comes back on ToT.
,
Jul 14 2017
re-open it for investigation.
,
Jul 14 2017
,
Jul 17 2017
We also have a canary for 61.0.3158 now, in case we were waiting for the change to propagate.
,
Jul 17 2017
,
Jul 17 2017
I've been using 61.0.3158.0 and have not seen this issue.
,
Jul 17 2017
,
Jul 17 2017
Still seen this issue on Chrome OS 9752.0.0, 61.0.3159.0
,
Jul 17 2017
Issue 744235 has been merged into this issue.
,
Jul 17 2017
I'm seeing black apps in ToT too now but reverting https://chromium-review.googlesource.com/c/566960/ doesn't solve it so this is a different issue.
,
Jul 18 2017
Did bisection and hit http://crbug.com/731742#c7 . So, the current issue is different from the original one and the original one is fixed. Closing. There's already an internal bug b/63667627 for the second breakage. Let's use the bug for the new regression. (and file a new Chromium bug when needed)
,
Jul 18 2017
Timeline BAD: 61.0.3155.0 Bug 741306 https://chromium-review.googlesource.com/c/566879/ GOOD: 61.0.3156.0 Revert https://chromium-review.googlesource.com/c/566863/ GOOD: 61.0.3157.0 Reland with fix https://chromium-review.googlesource.com/c/566960/ BAD: 61.0.3158.0 Yet another Bug 744235 https://chromium-review.googlesource.com/c/552719/
,
Jul 19 2017
Verified on kevin 9756.1.0/ 61.0.3159.8 but not fixed on 9759.0.0/61.0.3160.0
,
Jul 19 2017
Tested on Chrome:61.0.3160.0/9760.0.0 cave but its not fixed. attached screenshots.
,
Jul 19 2017
See #17, 61.0.3158.0 or above have a different bug ( Bug 744235 ), not this one. Fix for this bug can be verified using 61.0.3157.0 (9745.0.0).
,
Jul 24 2017
Verified on ChromeOS 9765.0.0, 61.0.3162.0 |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by kinaba@chromium.org
, Jul 12 2017