Chrome Version       : 61.0.3154.4
OS Version: OS X 10.12.5

What steps will reproduce the problem?
1. Navigate around a views bubble/dialog

What is the expected result?

Not having to go VO+Shift+Up/Down to get to all the elements. More meaningful names/announcements without having to enter/exit groups.


What happens instead of that?

Have to. See attached.


Currently views::RootView populates AXNodeData from WidgetDelegate::GetAccessibleWindowRole() (default AX_ROLE_WINDOW) and WidgetDelegate::GetAccessibleWindowTitle() (default: WidgetDelegate::GetWindowTitle())

DialogDelegate overrides GetAccessibleWindowRole():

ui::AXRole DialogDelegate::GetAccessibleWindowRole() const {
  return ui::AX_ROLE_DIALOG;
}


all good so far.

But then DialogDelegate *also* populates AXNodeData:

void DialogDelegateView::GetAccessibleNodeData(ui::AXNodeData* node_data) {
  node_data->SetName(GetWindowTitle());
  node_data->role = ui::AX_ROLE_DIALOG;
}


This sets up a weird dialog-within-a-dialog nesting that's confusing and hard to navigate. It gets worse when some BubbleDialogDelegateViews are also "ALERT" dialogs. So we have an alert dialog within a dialog which is not an alert.


To fix, I think we can just obey DialogDelegate::GetAccessibleWindowRole(). Put that in the RootView and don't give roles to any of the other containers.
 

Deleted: Screen Shot 2017-07-12 at 2.02.53 pm.png 38.7 KB

	Screen Shot 2017-07-12 at 2.02.53 pm.png 38.7 KB View Download

Deleted: Screen Shot 2017-07-12 at 2.03.16 pm.png 61.4 KB

	Screen Shot 2017-07-12 at 2.03.16 pm.png 61.4 KB View Download

Deleted: Screen Shot 2017-07-12 at 2.41.14 pm.png 33.8 KB

	Screen Shot 2017-07-12 at 2.41.14 pm.png 33.8 KB View Download