New issue
Advanced search Search tips

Issue 741284 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Remove ServiceWorkerURLRequestJob::DeliverErrorResponse

Project Member Reported by falken@chromium.org, Jul 12 2017

Issue description

Fix the TODO:
    // TODO(falken): This and below should probably be NotifyStartError, not
    // DeliverErrorResponse. But changing it causes
    // ServiceWorkerURLRequestJobTest.DeletedProviderHostBeforeFetchEvent to
    // fail.

This is a weird way to return a network error. We should be doing NotifyStartError instead.

Currently we're weirdly adding ServiceWorkerResponseInfo saying the request was intercepted by SW , etc, etc, to this 500 response in OnStartCompleted() when a lot of the values (like WorkerPreparationType) will be invalid.
 

Comment 1 by falken@chromium.org, May 14 2018

Status: WontFix (was: Assigned)
Obsolete by  bug 715640 : SWURLRequestJob will go away.

Sign in to add a comment