New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 741274 link

Starred by 2 users
Status: Started
Owner:
█ maajid@chromium.org
Last visit > 30 days ago
Cc:
xiy...@chromium.org
satorux@chromium.org
hashimoto@chromium.org
hidehiko@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Remove useless code in chromeos/cryptohome

Project Member Reported by hashimoto@chromium.org, Jul 12 2017 
Code in chromeos/cryptohome (e.g. HomedirMethods) is making the code unnecessarily complicated while providing almost no benefit.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d93e9273561f246160bfc9593243f54ed0232b71

commit d93e9273561f246160bfc9593243f54ed0232b71
Author: Ryo Hashimoto <hashimoto@chromium.org>
Date: Fri Jul 14 06:09:38 2017

chromeos: Remove cryptohome::MountParameters

HomedirMethods::MountEx was converting MountParameters to MountRequest proto.
To simplify this, remove MountParameters and use MountRequest everywhere.

- Construct MountRequest directly in MountEx's caller sites.
- Rename FillKeyProtobuf() in homedir_methods.cc to
KeyDefinitionToKey(), and make it public.

BUG=741274

Change-Id: Ibb8dd4a7975f6aff87ada881938be29300e7344c
Reviewed-on: https://chromium-review.googlesource.com/567844
Reviewed-by: Satoru Takabayashi <satorux@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486689}
[modify] https://crrev.com/d93e9273561f246160bfc9593243f54ed0232b71/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc
[modify] https://crrev.com/d93e9273561f246160bfc9593243f54ed0232b71/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
[modify] https://crrev.com/d93e9273561f246160bfc9593243f54ed0232b71/chromeos/cryptohome/cryptohome_parameters.cc
[modify] https://crrev.com/d93e9273561f246160bfc9593243f54ed0232b71/chromeos/cryptohome/cryptohome_parameters.h
[modify] https://crrev.com/d93e9273561f246160bfc9593243f54ed0232b71/chromeos/cryptohome/homedir_methods.cc
[modify] https://crrev.com/d93e9273561f246160bfc9593243f54ed0232b71/chromeos/cryptohome/homedir_methods.h
[modify] https://crrev.com/d93e9273561f246160bfc9593243f54ed0232b71/chromeos/cryptohome/mock_homedir_methods.h
[modify] https://crrev.com/d93e9273561f246160bfc9593243f54ed0232b71/chromeos/login/auth/cryptohome_authenticator.cc
[modify] https://crrev.com/d93e9273561f246160bfc9593243f54ed0232b71/chromeos/login/auth/extended_authenticator_impl.cc

Comment 2 by hashimoto@chromium.org, Nov 14 2017

Cc: hidehiko@chromium.org maajid@chromium.org
+hidehiko, maajid
While you are working on issue 765525, it'd be appreciated if you could also remove redundant code in chromeos/cryptohome (e.g. HomedirMethods).

Comment 3 by maajid@chromium.org, Nov 14 2017

Cc: -maajid@chromium.org hashimoto@chromium.org
Labels: -Pri-3 Pri-2
Owner: maajid@chromium.org

Comment 4 by maajid@chromium.org, Nov 14 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea50d55ce0a0169c777fdfd680e40396d656d94c

commit ea50d55ce0a0169c777fdfd680e40396d656d94c
Author: Maajid <maajid@chromium.org>
Date: Thu Nov 16 03:41:41 2017

Change call signature of GetKeyDataEx to use protos directly.

This CL helps prepare homedir_methods to purely passthrough-only,
which will eventually allow us to delete homedir_methods completely.

Bug: 741274
Change-Id: I4ec754fcb4708b89073b4263a8b0d63f84c5cae7
Reviewed-on: https://chromium-review.googlesource.com/770921
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Maajid <maajid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516971}
[modify] https://crrev.com/ea50d55ce0a0169c777fdfd680e40396d656d94c/chrome/browser/chromeos/login/easy_unlock/easy_unlock_get_keys_operation.cc
[modify] https://crrev.com/ea50d55ce0a0169c777fdfd680e40396d656d94c/chromeos/cryptohome/homedir_methods.cc
[modify] https://crrev.com/ea50d55ce0a0169c777fdfd680e40396d656d94c/chromeos/cryptohome/homedir_methods.h
[modify] https://crrev.com/ea50d55ce0a0169c777fdfd680e40396d656d94c/chromeos/cryptohome/homedir_methods_unittest.cc
[modify] https://crrev.com/ea50d55ce0a0169c777fdfd680e40396d656d94c/chromeos/cryptohome/mock_homedir_methods.cc
[modify] https://crrev.com/ea50d55ce0a0169c777fdfd680e40396d656d94c/chromeos/cryptohome/mock_homedir_methods.h
[modify] https://crrev.com/ea50d55ce0a0169c777fdfd680e40396d656d94c/chromeos/login/auth/cryptohome_authenticator.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f21b15cb932f79d903de8cff13e7a46f95c23ef2

commit f21b15cb932f79d903de8cff13e7a46f95c23ef2
Author: Maajid <maajid@chromium.org>
Date: Fri Nov 17 04:03:38 2017

Migrate all MountEx calls to use AuthorizationRequest directly.

Bug: 741274
Change-Id: I67b5093a83b06fda7b195afb29c361d410757fb8
Reviewed-on: https://chromium-review.googlesource.com/771134
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Maajid <maajid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517291}
[modify] https://crrev.com/f21b15cb932f79d903de8cff13e7a46f95c23ef2/chrome/browser/chromeos/policy/pre_signin_policy_fetcher.cc
[modify] https://crrev.com/f21b15cb932f79d903de8cff13e7a46f95c23ef2/chrome/browser/chromeos/policy/pre_signin_policy_fetcher_unittest.cc
[modify] https://crrev.com/f21b15cb932f79d903de8cff13e7a46f95c23ef2/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
[modify] https://crrev.com/f21b15cb932f79d903de8cff13e7a46f95c23ef2/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.h
[modify] https://crrev.com/f21b15cb932f79d903de8cff13e7a46f95c23ef2/chromeos/cryptohome/homedir_methods.cc
[modify] https://crrev.com/f21b15cb932f79d903de8cff13e7a46f95c23ef2/chromeos/cryptohome/homedir_methods.h
[modify] https://crrev.com/f21b15cb932f79d903de8cff13e7a46f95c23ef2/chromeos/cryptohome/mock_homedir_methods.h
[modify] https://crrev.com/f21b15cb932f79d903de8cff13e7a46f95c23ef2/chromeos/login/auth/cryptohome_authenticator.cc
[modify] https://crrev.com/f21b15cb932f79d903de8cff13e7a46f95c23ef2/chromeos/login/auth/extended_authenticator_impl.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/948778133e11c621e303172d4bd6013fb3f04a1b

commit 948778133e11c621e303172d4bd6013fb3f04a1b
Author: Maajid <maajid@chromium.org>
Date: Mon Nov 20 05:05:29 2017

Unify AuthorizationRequest creation methods.

This change should make it easier to make HomeDirMethods completely
pass-through, and eventually the method should live with CryptohomeClient.

Bug: 741274
Change-Id: I478f0de229cda544121fa57de870a6082f603961
Reviewed-on: https://chromium-review.googlesource.com/776533
Commit-Queue: Maajid <maajid@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517755}
[modify] https://crrev.com/948778133e11c621e303172d4bd6013fb3f04a1b/chromeos/cryptohome/homedir_methods.cc
[modify] https://crrev.com/948778133e11c621e303172d4bd6013fb3f04a1b/chromeos/cryptohome/homedir_methods.h
[modify] https://crrev.com/948778133e11c621e303172d4bd6013fb3f04a1b/chromeos/login/auth/extended_authenticator_impl.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/732b45e0edeed8fc2e83856c6d1fa5d00eb07720

commit 732b45e0edeed8fc2e83856c6d1fa5d00eb07720
Author: Maajid <maajid@chromium.org>
Date: Mon Nov 20 06:22:25 2017

Make AddKeyEx pass-through.

AddKeyEx now takes AuthorizationRequest and AddKeyRequest directly.

Bug: 741274
Change-Id: I200b7bd8255010b51376d15bcff3e190b651fb13
Reviewed-on: https://chromium-review.googlesource.com/776518
Commit-Queue: Maajid <maajid@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517762}
[modify] https://crrev.com/732b45e0edeed8fc2e83856c6d1fa5d00eb07720/chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.cc
[modify] https://crrev.com/732b45e0edeed8fc2e83856c6d1fa5d00eb07720/chrome/browser/chromeos/login/supervised/supervised_user_creation_browsertest.cc
[modify] https://crrev.com/732b45e0edeed8fc2e83856c6d1fa5d00eb07720/chrome/browser/chromeos/login/supervised/supervised_user_password_browsertest.cc
[modify] https://crrev.com/732b45e0edeed8fc2e83856c6d1fa5d00eb07720/chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc
[modify] https://crrev.com/732b45e0edeed8fc2e83856c6d1fa5d00eb07720/chromeos/cryptohome/homedir_methods.cc
[modify] https://crrev.com/732b45e0edeed8fc2e83856c6d1fa5d00eb07720/chromeos/cryptohome/homedir_methods.h
[modify] https://crrev.com/732b45e0edeed8fc2e83856c6d1fa5d00eb07720/chromeos/cryptohome/mock_homedir_methods.cc
[modify] https://crrev.com/732b45e0edeed8fc2e83856c6d1fa5d00eb07720/chromeos/cryptohome/mock_homedir_methods.h
[modify] https://crrev.com/732b45e0edeed8fc2e83856c6d1fa5d00eb07720/chromeos/login/auth/extended_authenticator_impl.cc
[modify] https://crrev.com/732b45e0edeed8fc2e83856c6d1fa5d00eb07720/chromeos/login/auth/extended_authenticator_impl.h

Comment 13 by maajid@chromium.org, Nov 29 2017

Cc: xiy...@chromium.org satorux@chromium.org

Comment 14 by maajid@chromium.org, Nov 29 2017

Components: OS>Systems
Project Member

Comment 16 by bugdroid1@chromium.org, Dec 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4618f860085d03527955529ca7517a8c08ef9302

commit 4618f860085d03527955529ca7517a8c08ef9302
Author: Maajid <maajid@chromium.org>
Date: Thu Dec 21 03:36:03 2017

Rename cryptohome_util to tpm_util.

Bug: 741274
Change-Id: I2890cb845dd2e74bdcc593411d9749eeb30efbf5
Reviewed-on: https://chromium-review.googlesource.com/836297
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Maajid <maajid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525584}
[modify] https://crrev.com/4618f860085d03527955529ca7517a8c08ef9302/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/4618f860085d03527955529ca7517a8c08ef9302/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
[modify] https://crrev.com/4618f860085d03527955529ca7517a8c08ef9302/chrome/browser/chromeos/settings/install_attributes.cc
[modify] https://crrev.com/4618f860085d03527955529ca7517a8c08ef9302/chrome/browser/chromeos/settings/install_attributes_unittest.cc
[modify] https://crrev.com/4618f860085d03527955529ca7517a8c08ef9302/chromeos/BUILD.gn
[rename] https://crrev.com/4618f860085d03527955529ca7517a8c08ef9302/chromeos/cryptohome/tpm_util.cc
[rename] https://crrev.com/4618f860085d03527955529ca7517a8c08ef9302/chromeos/cryptohome/tpm_util.h
[modify] https://crrev.com/4618f860085d03527955529ca7517a8c08ef9302/chromeos/dbus/fake_auth_policy_client.cc
[modify] https://crrev.com/4618f860085d03527955529ca7517a8c08ef9302/chromeos/login/auth/authpolicy_login_helper.cc
Project Member

Comment 17 by bugdroid1@chromium.org, Dec 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75b8ee405c07ef38f1d8c148421340970e49d507

commit 75b8ee405c07ef38f1d8c148421340970e49d507
Author: Maajid <maajid@chromium.org>
Date: Mon Dec 25 07:08:03 2017

Put cryptohome utility methods into cryptohome_util.

Bug: 741274
Change-Id: I935bf1e745d44cfafba0ee03ae12bc7c8325211e
Reviewed-on: https://chromium-review.googlesource.com/838880
Commit-Queue: Maajid <maajid@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526169}
[modify] https://crrev.com/75b8ee405c07ef38f1d8c148421340970e49d507/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc
[modify] https://crrev.com/75b8ee405c07ef38f1d8c148421340970e49d507/chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.cc
[modify] https://crrev.com/75b8ee405c07ef38f1d8c148421340970e49d507/chrome/browser/chromeos/login/easy_unlock/easy_unlock_remove_keys_operation.cc
[modify] https://crrev.com/75b8ee405c07ef38f1d8c148421340970e49d507/chromeos/BUILD.gn
[add] https://crrev.com/75b8ee405c07ef38f1d8c148421340970e49d507/chromeos/cryptohome/cryptohome_util.cc
[add] https://crrev.com/75b8ee405c07ef38f1d8c148421340970e49d507/chromeos/cryptohome/cryptohome_util.h
[modify] https://crrev.com/75b8ee405c07ef38f1d8c148421340970e49d507/chromeos/cryptohome/homedir_methods.cc
[modify] https://crrev.com/75b8ee405c07ef38f1d8c148421340970e49d507/chromeos/cryptohome/homedir_methods.h
[modify] https://crrev.com/75b8ee405c07ef38f1d8c148421340970e49d507/chromeos/login/auth/cryptohome_authenticator.cc
[modify] https://crrev.com/75b8ee405c07ef38f1d8c148421340970e49d507/chromeos/login/auth/extended_authenticator_impl.cc
Project Member

Comment 18 by bugdroid1@chromium.org, Jan 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67803fe02870ac7833a30d3c71b15fe0aea159db

commit 67803fe02870ac7833a30d3c71b15fe0aea159db
Author: Maajid <maajid@chromium.org>
Date: Fri Jan 05 09:55:18 2018

Remove MountEx from HomedirMethods.

Bug: 741274
Change-Id: I1c8ac238104bb51f31966fe98a906b99073ef35f
Reviewed-on: https://chromium-review.googlesource.com/823583
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Maajid <maajid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527247}
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chrome/browser/chromeos/login/supervised/supervised_user_authenticator.cc
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chrome/browser/chromeos/login/supervised/supervised_user_authenticator.h
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chrome/browser/chromeos/login/supervised/supervised_user_creation_browsertest.cc
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chrome/browser/chromeos/login/supervised/supervised_user_password_browsertest.cc
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chrome/browser/chromeos/login/supervised/supervised_user_test_base.h
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chrome/browser/chromeos/policy/pre_signin_policy_fetcher.cc
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chrome/browser/chromeos/policy/pre_signin_policy_fetcher.h
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chrome/browser/chromeos/policy/pre_signin_policy_fetcher_unittest.cc
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.h
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler_unittest.cc
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chromeos/cryptohome/cryptohome_util.cc
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chromeos/cryptohome/cryptohome_util.h
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chromeos/cryptohome/homedir_methods.cc
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chromeos/cryptohome/homedir_methods.h
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chromeos/cryptohome/mock_homedir_methods.cc
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chromeos/cryptohome/mock_homedir_methods.h
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chromeos/dbus/cryptohome_client.h
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chromeos/dbus/fake_cryptohome_client.h
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chromeos/login/auth/auth_attempt_state.cc
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chromeos/login/auth/auth_attempt_state.h
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chromeos/login/auth/cryptohome_authenticator.cc
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chromeos/login/auth/extended_authenticator_impl.cc
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chromeos/login/auth/extended_authenticator_impl.h
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chromeos/login/auth/test_attempt_state.cc
[modify] https://crrev.com/67803fe02870ac7833a30d3c71b15fe0aea159db/chromeos/login/auth/test_attempt_state.h
Project Member

Comment 19 by bugdroid1@chromium.org, Jan 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b434839d7f0a78b7c621aa5ad9d5bb0ae7afc83

commit 1b434839d7f0a78b7c621aa5ad9d5bb0ae7afc83
Author: Maajid <maajid@chromium.org>
Date: Fri Jan 19 04:46:54 2018

Remove RenameCryptohome from HomedirMethods.

Bug: 741274
Change-Id: Ib6a62720c7f3e89a7d480a63c4bc4a470d75aed9
Reviewed-on: https://chromium-review.googlesource.com/861368
Commit-Queue: Maajid <maajid@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530423}
[modify] https://crrev.com/1b434839d7f0a78b7c621aa5ad9d5bb0ae7afc83/chrome/browser/chromeos/policy/pre_signin_policy_fetcher.cc
[modify] https://crrev.com/1b434839d7f0a78b7c621aa5ad9d5bb0ae7afc83/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
[modify] https://crrev.com/1b434839d7f0a78b7c621aa5ad9d5bb0ae7afc83/chromeos/cryptohome/cryptohome_util.cc
[modify] https://crrev.com/1b434839d7f0a78b7c621aa5ad9d5bb0ae7afc83/chromeos/cryptohome/cryptohome_util.h
[modify] https://crrev.com/1b434839d7f0a78b7c621aa5ad9d5bb0ae7afc83/chromeos/cryptohome/homedir_methods.cc
[modify] https://crrev.com/1b434839d7f0a78b7c621aa5ad9d5bb0ae7afc83/chromeos/cryptohome/homedir_methods.h
[modify] https://crrev.com/1b434839d7f0a78b7c621aa5ad9d5bb0ae7afc83/chromeos/cryptohome/mock_homedir_methods.h
[modify] https://crrev.com/1b434839d7f0a78b7c621aa5ad9d5bb0ae7afc83/chromeos/login/auth/cryptohome_authenticator.cc
[modify] https://crrev.com/1b434839d7f0a78b7c621aa5ad9d5bb0ae7afc83/chromeos/login/auth/extended_authenticator_impl.cc
Project Member

Comment 20 by bugdroid1@chromium.org, Feb 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ead81324c537815b3218a89c771299d5807e3983

commit ead81324c537815b3218a89c771299d5807e3983
Author: Maajid <maajid@chromium.org>
Date: Wed Feb 14 02:21:31 2018

Remove GetAccountDiskUsage from HomedirMethods.

Bug: 741274
Change-Id: I9f6fd3e312d000b7334f465d97636f23e2e22cfe
Reviewed-on: https://chromium-review.googlesource.com/915681
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Maajid <maajid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536618}
[modify] https://crrev.com/ead81324c537815b3218a89c771299d5807e3983/chrome/browser/ui/webui/settings/chromeos/device_storage_handler.cc
[modify] https://crrev.com/ead81324c537815b3218a89c771299d5807e3983/chrome/browser/ui/webui/settings/chromeos/device_storage_handler.h
[modify] https://crrev.com/ead81324c537815b3218a89c771299d5807e3983/chromeos/cryptohome/cryptohome_util.cc
[modify] https://crrev.com/ead81324c537815b3218a89c771299d5807e3983/chromeos/cryptohome/cryptohome_util.h
[modify] https://crrev.com/ead81324c537815b3218a89c771299d5807e3983/chromeos/cryptohome/cryptohome_util_unittest.cc
[modify] https://crrev.com/ead81324c537815b3218a89c771299d5807e3983/chromeos/cryptohome/homedir_methods.cc
[modify] https://crrev.com/ead81324c537815b3218a89c771299d5807e3983/chromeos/cryptohome/homedir_methods.h
[modify] https://crrev.com/ead81324c537815b3218a89c771299d5807e3983/chromeos/cryptohome/mock_homedir_methods.h
Project Member

Comment 21 by bugdroid1@chromium.org, Feb 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6107dd175be7849918da34e555b4baaa81df2cd

commit f6107dd175be7849918da34e555b4baaa81df2cd
Author: Maajid <maajid@chromium.org>
Date: Tue Feb 27 02:43:37 2018

Remove GetKeyDataEx from HomedirMethods.

Bug: 741274
Change-Id: I8233e0cbc063642ebc8a876ad6a39d7905f2e927
Reviewed-on: https://chromium-review.googlesource.com/927936
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Maajid <maajid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539382}
[modify] https://crrev.com/f6107dd175be7849918da34e555b4baaa81df2cd/chrome/browser/chromeos/login/easy_unlock/easy_unlock_get_keys_operation.cc
[modify] https://crrev.com/f6107dd175be7849918da34e555b4baaa81df2cd/chrome/browser/chromeos/login/easy_unlock/easy_unlock_get_keys_operation.h
[modify] https://crrev.com/f6107dd175be7849918da34e555b4baaa81df2cd/chromeos/BUILD.gn
[modify] https://crrev.com/f6107dd175be7849918da34e555b4baaa81df2cd/chromeos/cryptohome/cryptohome_util.cc
[modify] https://crrev.com/f6107dd175be7849918da34e555b4baaa81df2cd/chromeos/cryptohome/cryptohome_util.h
[modify] https://crrev.com/f6107dd175be7849918da34e555b4baaa81df2cd/chromeos/cryptohome/cryptohome_util_unittest.cc
[modify] https://crrev.com/f6107dd175be7849918da34e555b4baaa81df2cd/chromeos/cryptohome/homedir_methods.cc
[modify] https://crrev.com/f6107dd175be7849918da34e555b4baaa81df2cd/chromeos/cryptohome/homedir_methods.h
[delete] https://crrev.com/c10798ac190a3acf00fab6fcb6d7c969e128c773/chromeos/cryptohome/homedir_methods_unittest.cc
[modify] https://crrev.com/f6107dd175be7849918da34e555b4baaa81df2cd/chromeos/cryptohome/mock_homedir_methods.cc
[modify] https://crrev.com/f6107dd175be7849918da34e555b4baaa81df2cd/chromeos/cryptohome/mock_homedir_methods.h
[modify] https://crrev.com/f6107dd175be7849918da34e555b4baaa81df2cd/chromeos/login/auth/cryptohome_authenticator.cc
Project Member

Comment 22 by bugdroid1@chromium.org, Jul 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/386e728c768c23d640201bfe9d90a07aa14cb474

commit 386e728c768c23d640201bfe9d90a07aa14cb474
Author: Ryo Hashimoto <hashimoto@chromium.org>
Date: Tue Jul 31 09:11:16 2018

chromeos: Replace Identification in chromeos/dbus with AccountIdentifier

Replace Identification arguments of CryptohomeClient and SessionManagerClient with AccountIdentifier.
Add and use conversion functions to create AccountIdentifier from other
types.
Change the key type of SessionManagerClient::ActiveSessionMap to
std::string.

BUG=741274
TEST=build

TBR=msramek@chromium.org for changes under chrome/browser/browsing_data/

Change-Id: Iaa4518f5a6f37f6ac3b89e965ffa59412ffde5cc
Reviewed-on: https://chromium-review.googlesource.com/1144814
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579354}
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/chromeos/app_mode/kiosk_crash_restore_browsertest.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/chromeos/arc/boot_phase_monitor/arc_boot_phase_monitor_bridge.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/chromeos/attestation/attestation_policy_observer.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/chromeos/login/auto_launched_kiosk_browsertest.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/chromeos/login/crash_restore_browsertest.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/chromeos/login/easy_unlock/easy_unlock_get_keys_operation.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/chromeos/login/quick_unlock/pin_storage_cryptohome.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/chromeos/login/saml/saml_browsertest.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/chromeos/login/users/wallpaper_policy_browsertest.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/chromeos/policy/affiliation_test_helper.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/chromeos/policy/cached_policy_key_loader_chromeos.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/chromeos/policy/cached_policy_key_loader_chromeos_unittest.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/chromeos/policy/power_policy_browsertest.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/chromeos/policy/pre_signin_policy_fetcher.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/chromeos/policy/pre_signin_policy_fetcher_unittest.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/chromeos/policy/site_isolation_flag_handling_browsertest.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/chromeos/policy/user_affiliation_browsertest.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/policy/cloud/cloud_policy_browsertest.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler_unittest.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chrome/browser/ui/webui/settings/chromeos/device_storage_handler.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chromeos/BUILD.gn
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chromeos/attestation/attestation_flow.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chromeos/attestation/attestation_flow_unittest.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chromeos/cryptohome/async_method_caller.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chromeos/cryptohome/cryptohome_parameters.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chromeos/cryptohome/cryptohome_parameters.h
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chromeos/cryptohome/homedir_methods.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chromeos/dbus/cryptohome_client.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chromeos/dbus/cryptohome_client.h
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chromeos/dbus/fake_auth_policy_client.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chromeos/dbus/fake_cryptohome_client.h
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chromeos/dbus/fake_cryptohome_client_unittest.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chromeos/dbus/fake_session_manager_client.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chromeos/dbus/fake_session_manager_client.h
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chromeos/dbus/session_manager_client.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chromeos/dbus/session_manager_client.h
[add] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chromeos/dbus/util/account_identifier_operators.cc
[add] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chromeos/dbus/util/account_identifier_operators.h
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chromeos/login/auth/cryptohome_authenticator.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chromeos/login/auth/extended_authenticator_impl.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chromeos/tpm/tpm_token_info_getter.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/chromeos/tpm/tpm_token_info_getter_unittest.cc
[modify] https://crrev.com/386e728c768c23d640201bfe9d90a07aa14cb474/components/arc/arc_data_remover.cc
►

Sign in to add a comment