New issue
Advanced search Search tips

Issue 741228 link

Starred by 2 users

Issue metadata

Status: Archived
Owner: ----
Closed: Jul 13
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Presubmit crash in owners.py

Project Member Reported by brettw@chromium.org, Jul 12 2017

Issue description

I was uploading patch set 8 of
https://chromium-review.googlesource.com/c/564157/
and got this error when I did "git cl upload":

brettw2[~/prj/src] git cl upload -m Better
Running presubmit upload checks ...
Traceback (most recent call last):
  File "/usr/local/google/home/brettw/depot_tools/git_cl.py", line 6055, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/usr/local/google/home/brettw/depot_tools/git_cl.py", line 6037, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/usr/local/google/home/brettw/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/usr/local/google/home/brettw/depot_tools/git_cl.py", line 4904, in CMDupload
    return cl.CMDUpload(options, args, orig_args)
  File "/usr/local/google/home/brettw/depot_tools/git_cl.py", line 1635, in CMDUpload
    change=change)
  File "/usr/local/google/home/brettw/depot_tools/git_cl.py", line 1567, in RunHook
    gerrit_obj=self._codereview_impl.GetGerritObjForPresubmit())
  File "/usr/local/google/home/brettw/depot_tools/presubmit_support.py", line 1348, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/usr/local/google/home/brettw/depot_tools/presubmit_support.py", line 1258, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 2358, in CheckChangeOnUpload
  File "<string>", line 2096, in _CommonChecks
  File "<string>", line 1113, in _CheckAddedDepsHaveTargetApprovals
  File "/usr/local/google/home/brettw/depot_tools/owners.py", line 173, in files_not_covered_by
    self._check_paths(files)
  File "/usr/local/google/home/brettw/depot_tools/owners.py", line 184, in _check_paths
    _is_under(f, self.os_path.abspath(self.root)) for f in files)
AssertionError

 
Labels: TE-NeedsTriageHelp
This issue seems to be out of TE-scope. Hence, adding label TE-NeedsTriageHelp for further investigation.

Thanks!
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 13

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment