New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 741222 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Do not copy over strides in libyuv::I420Copy in MediaFoundationVideoEncodeAccelerator

Project Member Reported by emir...@chromium.org, Jul 12 2017

Issue description

Although coded_size is not updated, there might be padding in strides due to the allocation scheme of VideoFrame::CreateFrame(), see below explanation for the failing test and details:
https://bugs.chromium.org/p/libyuv/issues/detail?id=709#c1
 
Cc: gusss@google.com
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e3aa32f08ee2cd0b907f5a9460c43be3a9878f1

commit 4e3aa32f08ee2cd0b907f5a9460c43be3a9878f1
Author: Emircan Uysaler <emircan@chromium.org>
Date: Wed Jul 12 02:45:25 2017

Do not copy over strides in libyuv::I420Copy in MediaFoundationVideoEncodeAccelerator

This CL uses strides based on the allocated buffer rather than copying over.

Bug:  741222 
Test: Proposed test in the bug report passes with this CL.
Change-Id: Icfd006fd1d615c780a28a5f08fb9aafb56d566e6
Reviewed-on: https://chromium-review.googlesource.com/567720
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485817}
[modify] https://crrev.com/4e3aa32f08ee2cd0b907f5a9460c43be3a9878f1/media/gpu/media_foundation_video_encode_accelerator_win.cc
[modify] https://crrev.com/4e3aa32f08ee2cd0b907f5a9460c43be3a9878f1/media/gpu/media_foundation_video_encode_accelerator_win.h

Status: Fixed (was: Started)

Sign in to add a comment